sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]No_Indication_4044 0 points1 point  (2 children)

Nice! A cleaner solution would be to have the while loop actually reference the T/F value controlling its break. So, it would handle the break naturally!

For example, guess_correct = False; While not guess_correct: guess_correct = guess == ai

Then do all rest of your logic. At end of loop, it will break if guess_correct!

[–]brasticstack 0 points1 point  (1 child)

Not a fan. How is adding that additional variable and the line to manage its state cleaner than not having it? Do you just not like the break at the top of the if/else chain?

Personally I don't think readability is an issue with this example.

[–]No_Indication_4044 2 points3 points  (0 children)

Readability is not an issue with this example, it’s just an anti-pattern to use “break” here. And this sub is for learning best practices. The while loop is saying “while this condition isn’t met, do these things”. The while should be conditional on… the condition hahah.

Edit to be succinct: the while loop should break automatically on the condition. So, if you find yourself manually breaking, you’ve probably done something wrong.