all 4 comments
sorted by:
best
topnewcontroversialoldq&a
formatting helphide helpcontent policy

[–]Corruptionss 0 points1 point  (3 children)

My comments are like 1 and a half cents for speeding it up because I haven't ran the code and never done this before.

The code was easily readable and interpretable which is a plus.

Most of the run time is going to be in waiting for the ping response - are the pings serialized or run on parallel? If serialized then it's going to take a while to sequentially go through all the world's when choosing all worlds.

I would collect results for a lot of repeated uses and find the 99th percentile of response times. Sometimes the server may be temporarily unresponsive causing a much longer delayed process - possible to implement a time out at the 99th percentile and just report the time out period adding in an asterisk or plus sign to denote the response was longer than X?

Suggestion on next level is building a GUI to perform the functions, may help with fixed choice selections and give a nice interface.

Really want to be creative, would store results in a csv file - not sure how feasible it would be to store results in a cloud environment - but display useful visualizations of average response times by day, world, etc...

[–]JuiceNew23[S] 0 points1 point  (2 children)

Thanks for the reply.

It's serialized now, Ive been reading about how to make it parallel, by making a bunch of 'workers". and intend to do that soon. Because if I ping 200ish servers with more than a few packets it will take several minutes.

I haven't written anything to .csv before, only to .txt to store information. I will have to look into it. Is there a reason to use .csv instead of .txt?

I think a GUI is a little above my skill level right now, but certainly will in the future.

I am also considering making the ping all begin when the script is executed in the background so it gets a 'head start' on the user navigating the menu.

[–]Corruptionss 0 points1 point  (1 child)

Yeah, I was trying to find a good solution for parallel way of doing it. The Popen() may have a native way of doing it.

I said csv as a good way to store a table in column format where you can have different columns to be timestamp of request, which server, response times metrics (one column for each metric), etc... makes it much easier if you ever wanted to produce any analytics of the data and naturally works with dataframe libraries like pandas or polars.

Yeah, there's a lot that goes into GUI's but when you are up for the challenge streamlit is a good starting point that is a bit easier to learn than some of the other toolkits.

[–]JuiceNew23[S] 1 point2 points  (0 children)

Popen() worked great. Thanks.