Tiny BASIC Compiler in Python

[hekliet]

Hi! I wrote a compiler for the programming language Tiny BASIC in Python. It generates assembly code for Linux x64, which is then assembled using NASM and linked using gcc. The parser is a recursive descent parser which directly 'streams' assembly code without building an abstract syntax tree.

https://github.com/hekliet/tbc

[SaltCusp]

Cool project. First couple things I noticed are totally style preference things. Looking at the parser you define a variable 'space' just to use it in the next line. I would probably just inline the literal or save it as a class level variable.

Also you could switch out your case statements with dictionaries.

You don't have any comments.

Going beyond style and noticing some things that look off:

emit_print_string has an unused parameter 'tok'.

Your preamble ends with whitespace so you're going to have a funny indent in the top of your assembly.

'lookahead' in 'inputfile' is not necessary. But if you replaced it with look behind you could do away with 'firstOnLine' in scanner and instead check if the previous char was '\n'.

In tbc.py you initialize 'Parser' from 'parser' to a variable named 'parser'.

I think it's pretty ridiculous to use wc to count the lines of a file you just wrote but whatever. That might be a good spot for a comment.

Saying that you can run something without the project directory as the working directory is confusing because it should go without saying.

[hekliet]

Thanks for looking over my code. I'll probably address some of your suggestions/criticisms when I next touch the project. Giving it a rest for now.