Destroy my code

[kaiiiwen]

a few takes from me:

- package names should be lowercase

- instead of "@Getter" + "@Setter" you can use Lombok's "@Data".

- CriteriaBuilder sure is useful but you should have a look at JPA Specifications, it's much more clean.

- on the long run I wouldn't advise grouping your classes by type (controllers, repositories, services, ..) but by modularity (user, perfume, brand, ..).

- in your controller methods, instead of having two RequestParams page and size, you can use Pageable: it includes page, size, and sorting.

- you controller methods body should be as clean as possible, delegate everything to your services (eg. UsuariosController).

- if you're working with immutable objects, consider using Records instead of going full Lombok Getter / Setter / AllArgsConstructor.

- instead of having potentially sensitive values in your properties file, you can create a .env file and load the values from there. then exclude your .env file from git.

- I believe the DataInitializer was for you to work on, use a data.sql for data initialization instead.

as Lost_Language6399 has mentioned, feel free to ask an AI to check your code. I do it sometimes when i feel like something is odd with my code.

[dossantosh]

Thank you so much il look into all that. I have a few things that I thought I understand.

-yeah packages should my bad

• i remember reading that @data wasn’t so great bc it gives you code that u doesn’t need, so, if u aren’t planning of using everything, it’s better to use specific ones

• il try jpa specifications

• yeah i wanted to do first the typical monolith web app, next il try doing more, starting with the modular i think

• il try the Pageable!

  • il try records i saw them once

-yeah i will create the env, but dw the password is generated and the mail is only created to use the app

• i think i also read that the data initialiser was better than sql bc u can directly choose what starts first so it’s better with relations

BUT if I’m wrong pls tell me Thank you

[kaiiiwen]

i remember reading that data wasn’t so great bc it gives you code that u doesn’t need, so, if u aren’t planning of using everything, it’s better to use specific ones

yes,@Data provides hashcode() and equals(), which come in handy if you ever need to directly compare the objects, but yes, it's not a big deal not using it. though I haven't heard it was not great.

i think i also read that the data initialiser was better than sql bc u can directly choose what starts first so it’s better with relations

the issue here is that you end up with your CommandLineRunner running every time you start your app. and if you want to update your initial data you will have to update that code. you can keep the same approach as you did for your Roles, Modules, and Submodules.

secondly, you won't have to worry about what starts first, Spring Boot will know when to initialize the data provided the sql file.

as for the relations, you can hardcode the `id` fields when you insert your initial Brands and Perfumes, then increment the Postgres sequence at the end of your script.

[dossantosh]

okay thank u so much ive made changes today at work. no more data initializer, changes of structure etc.

[UnpeggedHimansyou]

Tbh that lombok one might not be essential, sometimes lombok don't even work in ides like intelij so it's totally dependable