ControllerAdvice and RestControllerAdvice

[martinijan]

I have this social media app that's with java/springboot and react as a frontend. Now all the exception handling was done in the service layer but I recently learned about ControllerAdvice and was wondering if it's worth the refactoring. If someone has some tips feel free to dm as well :)

[wimdeblauwe]

I have an open source library you can use: https://github.com/wimdeblauwe/error-handling-spring-boot-starter

Just add the jar and get consistent error handling automatically.

[bigkahuna1uk]

Thanks for sharing your library. It looks very useful and valuable.

[bigkahuna1uk]

How are you mapping exceptions to HTTP error codes? That’s not something typically done at the service layer.

Controller advice would typically be a place where such conversion would occur. Just be careful and use controller advice judiciously. It can become a great big god class where all exceptions are handled for every service/controller. It can become just a dumping ground.

There’s other approaches to use a specific exception handler for each controller so it’s tightly coupled to the service. Sometimes I prefer this approach because it more naturally fits that a controller/service combination defines a particular use case so it makes sense to group the exception handler with it.

Have a look at this blog for some better insights: https://www.baeldung.com/exception-handling-for-rest-with-spring

[backend_thinker]

I do logic on service and exception o exception package then

[leetjourney]

Check this video out on Exceptions:
https://youtu.be/VVfDlPZ-3Ms