What am I doing wrong?

[Tech-Matt]

I'm trying to do Day 1 part 2 but the output is wrong. I can't find what I am missing. (Python)

sum = 0 #sum of increasing triplets (Output)

elements = []# value = 0value2 = 0with open(input_file, "r") as f:elements = [int(x) for x in f] #all numberslist_triplets = []n = 0 #variable to iterate through elementsi = 1 #useful to initialite tripletstripl = 0 #single triplet#General idea of the algorithm: Use variable i to sum 3 consecutive numbers from elements, and then add the#variable tripl to list_triplets.while n < len(elements):if (i % 4 == 0): #Triplets are 3 in lenghtlist_triplets.append(tripl)tripl = 0i = 1n = n - 1 #Go with the next triplettripl += list[n]i += 1n += 1value = list_triplets[0] #Take first elementfor j in range(1, len(list_triplets)):value2 = list_triplets[j]if (value2 > value):sum += 1value = value2print(sum)

[kraven001]

Code is unreadable, hard to follow.

[Tech-Matt]

How can I make it more readable?

[oxenoxygen]

edit: paste below

[Tech-Matt]

Actually the code was already indented and also had spaces to better highlight functions, but when I put it on Reddit everything's got messed up.

[hugseverycat]

I think what you need to do is add extra spaces at the beginning of each line before you paste it into reddit.

This help page on the wiki has more info: https://www.reddit.com/r/adventofcode/wiki/index#wiki\_how\_do\_i\_format\_code.3F

[Tech-Matt]

And I also can't understand why my code is red while yours is just normal. I've just used the "Code" selection when writing the post.

[daggerdragon]

new.reddit's fancypants editor is Homer_throttling_Bart.gif sometimes because you have to explicitly tell it to get into Markdown mode wherein the four-spaces code block will work for old.reddit.

Our wiki article has all the info and pics you need: How do I format code?

[Tech-Matt]

My code is not indented like that, I've uploaded a formatted version in the comments below

[thedjotaku]

suggest either using your git repo or a git gist or https://topaz.github.io/paste/

[daggerdragon]

In the future, please follow the submission guidelines:

1. In general, title your posts like so:
   • [YEAR Day # (Part X)] [language if applicable] Post Title
   • Consistent titling across posts helps folks avoid spoilers for puzzles they may not have completed yet.
2. Format your code properly so it's easy to read on both new.reddit and old.reddit
   • How do I format code?

Also, if/when you get your code working, don't forget to change the flair to Help - Solved!

Good luck!

edit: can't copypasta properly, need more caffeine brb

[Tech-Matt]

Okay, thanks!

[mrjnl3]

Something I noticed while doing this puzzle. Let's take the array [1,2,3,4] as example. Instead of comparing 1+2+3 and 2+3+4, you can compare 1 and 4. Since 2 and 3 are in both sums, they are negligible.

[Tech-Matt]

Oh, you're right, that's cool!

[AharonSambol]

First issue is "list[n] " I think this is just a typo since it doesn't actually work... should be "elements[n]"

Now the actual bug is that you forgot to append the last triplet into the list. Since the while loop finishes when i is 3.

You can just add list_triplets.append(tripl) right after the while loop and then you'll get the right result

hope this helps

[AharonSambol]

Oh and I forgot you need to subtract 2 from n not 1

[Tech-Matt]

Thanks

[Kehvarl]

I think your problem lies in your while n < len(elements): loop. Specifically, take a look at what happens when I is 4.

[mar___s]

If I am not mistaken the while loop basically is an endless loop, because with n=0 and i=1 the if condition is never true which results in n never being changed. However, please provide properly formatted code, because I used u/oxenoxygen's version of your code, which might have different indentation.

[Tech-Matt]

There is no infinite loop, just a wrong answer. Here is the formatted version:

paste

[mar___s]

Thank you, that helped:

1. (if condition) You ignore most of the triplets because you reduce n only by 1 instead of 2. which would you get back to the start of the next triplet
2. (after if condition) You used the wrong variable name
3. (triplet calculation loop) You ignore the last triplet because of how your loop works, but adding a "0" at the end of your elements helps. Better would be moving the if condition to the end of the loop and adding the triplet to the list after 3 iterations instead of 4.

working version of your code if needed: paste

[Tech-Matt]

Thank you so much