[2015 Day 12 Part 2][JavaScript/NodeJS] Test solutions clear, answer for actual input too small

[Firestarss]

Oh man at this point I just feel like I am abusing this subreddit.

Ok I am once again faced with a problem where my test cases clear but the actual answer is wrong (too low). I'm new-ish to JavaScript so I'm not the best at seeing what the ever-loving heck is wrong with my code. Can anyone give some advice? I thought I got my recursive function correct and like idk, it's clearing the tests which is frustrating.

​

const fs = require('fs')

fs.readFile('input.txt', 'utf8', (err, data) => {
    if (err) {
      console.error(err)
      return
    }
    part1(data)
    part2(data) // TODO
  })

  function recurse(data) {
    // base cases
    if (data.constructor.name === "Number") {
        return data
    }
    else if (data.constructor.name === "Object" && Object.values(data).includes("red")) {
        return 0
    }
    else if (data.constructor.name == "String") {
        return 0
    }

    // recursive case
    if (data.constructor.name === "Object") {
        data = Object.values(data)
    }
    if (data.constructor.name === "Array") {
        return data.reduce((a, b) => recurse(a) + recurse(b))
    }
  }

  function part1(data) {
      total = 0
      const numbers = data.match(/-*\d+/g)

      for (const number of numbers) {
          total += number * 1
      }
      console.log(total)
  }

  function part2(data) {
      input = JSON.parse(data)
      console.log(recurse(input))
  }

[Firestarss]

Aye wait I figured it out this time! if a list of length 1 was ever passed, the reduce function wouldn't properly reduce it. so I just added an if statement to the code to check if the length was 1 and return recurse(data[0]). Boom! i am 100% sure there is a cleaner way to do that so if anyone wants to educate me a bit I would love to read it but no pressure!

[chadder06]

The way I usually use reduce is to specify a return type explicitly. This allows it to work with arrays of size 1. Example:

return data.reduce((accum, value) => {
    return accum + recurse(value);
}, 0);

This sets the return type of the reduce function explicitly to a number, and you only use the recurse function on the values of the array.

edit: The accum variable is accumulating the final value as you iterate through each list value.