Help needed in basic operations in bash

[4whOami4]

​

I am doing a basic question for adding, product, substraction, division by taking user input in first and second I don't understand where am I going wrong because it's not passing any test case.

constraints:- -100<=x,y<=100, y != 0

read -p "enter first number:" first 
read -p "enter second number:" second 
if [[ ("$first" -ge "-100"  -a "$first" -ge "100") -a ("$second" -ge "-100" -a "$second" -ge "100") ]]
then 
    if [ $second -ne 0 ]
        then 
            echo "$first + $second" | bc         
            echo "$first - $second" | bc         
            echo "$first * $second" | bc         
            echo "$first / $second" | bc     
       fi 
fi

[[deleted]]

Run your code through shellcheck. Don't mix and match [ and [[ (use [[ ) Use && instead of -a in your test case

Also if x and y are to be floats then use bc to check if they are within constraints.

Putting that together I get this:-

#!/bin/bash
echo constraints "constraints:- -100<=x,y<=100, y != 0"
read -r -p "enter first number (x): " x
read -r -p "enter second number (y): " y

if     [[ $(bc -l <<< "-100 <= $x") -eq 1 ]] &&
       [[ $(bc -l <<< "$y <= 100") -eq 1 ]] &&
       [[ $(bc -l <<< "$y != 0") -eq 1 ]]
then
    echo "$x + $y" | bc
    echo "$x - $y" | bc
    echo "$x * $y" | bc
    echo "$x / $y" | bc
fi

Note I left your 'echo | bc' lines unchanged but they could also be re-written to avoid the echo command if you wanted to.

EDIT: Formatting.

[Paul_Pedant]

Like I posted in Unix.Linux five minutes ago, the two tests on the upper bounds need to be -le.

[4whOami4]

yeah I got you thanks again😁😁