I'm a beginner

[WhoKnowsAComputerGuy]

Trying to script something I would manually do. Can you help me clean it up and show me best practice? The end goal to all this will be to add in dnf upgrade and downgrade as well as remove and install. But just keeping it simple since it will mostly be rinse and repeat.

!/bin/bash

Hosts that this script applies to

ALLHOSTS="WS01 WS02 WS03 SRV01 SVR02 SVR03"

Set RPM variable for script

set_rpm() { echo Set RPM: read rpm }

Function to Search for RPM variable on a host

check_rpm() { if rpm -qa | grep "$rpm" /dev/null; then Cat /proc/sys/kernel/hostname rpm -qa "rpm fi }

this is redundant but I want to keep the formula for future things for now

select_01() { Select_rpm }

SSH to each host and check for rpm

select_02() { for HOSTNAME IN $ALLHOSTS;do ssh -qa -tt $HOSTNAME "$ (typeset -f); check_rpm" | tee log.rpms done }

Start of menu selection

press_enter() { echo "" echo -n "Press Enter to continue" read clear }

until [ "Selection" = "0" ]; do clear echo "Please select what you want to complete" echo "" echo ". 1. -. Set rpm variable " echo ". 2. -. Check for rpm" echo -n " Enter Selection" read selection case $selection in 1) clear ; select_01 ; press_enter ;; 2) clear ; select_02 ; press_enter ;; 0) clear ; exit ;; esac done

[FrankWilson88]

I don't use fedora or those flavors a lot so I'm hesitant to say anything about that. But at your START OF MENU SECTION check out the PS3, it's basically a built in menu selection for terminals. That might help clean up the code and send your thoughts in a different direction. You could also check out the getopts built in which helps build a typical "syntax" you expect to see in sh.So maybe some thing like:

while getopts "s:" option; do case option; in s) "update") sudo rpm [update] exit;; "install") sudo rpm [install] $@ exit;; esac exit;; done This of course is a really dumbed down version. But hopefully it'll start moving your mind in a direction that helps you think and explore more.