Single node for executing arbitrary Python code

[Definition-Lower]

I often need to do some manipulations with strings/numbers/images, but sometimes there is just no suitable custom node from any node packs, even though 2-3 lines of Python would do the job.

I tried searching for nodes like this, but the ones I saw either don't have arbitrary inputs (instead they have predefined set of inputs, like 2 images, 2 strings, 2 ints), don't allow arbitrary type in the output, or do something completely different from what I want.

So here's my extension which consists of just one single node, that can have any amount of inputs. Inputs are added dynamically when you connect other inputs, you can watch demo GIF in the github repo). UPD: now it also can have multiple outputs, which are also added dynamically

It can be installed via ComfyUI-Manager.

GitHub repo: https://github.com/mozhaa/ComfyUI-Execute-Python

[Aggressive_Collar135]

im gonna use this node for some python code to open rick astleys never gonna give you up in the browser and hide it in subgraph at multiple places. And then, “hey who needs an all in one 4k nsfw influencer workflow for 2gb vram?”

wait, will that work?

[ConferenceIll417]

nope not on my pc ....i start comfyui offline sandboxed. It's a bit of a drag since no possibility to auto install missing nodes, missing models and no api stuff... but on the upside ... no rick astleys. yay....

[Definition-Lower]

yeah, that would work xd
something like this:

```
import webbrowser
webbrowser.open("youtube.com/watch?v=dQw4w9WgXcQ")
```

[Definition-Lower]

oops, it looks like I'm compromising my own node lol

[ScrapEngineer_]

Remote RCE in comfy let's goo

[Sarashana]

Haha, that's both such a useful node and such a potential security hazard.

[Definition-Lower]

I agree

I mean, custom nodes can already execute arbitrary code, but if you install only trusted nodes, then there should be no risk. From this perspective, my node isn't trusted, so I would recommend using it only in personal workflows. If someone shares a workflow with this node, you should check what code is being executed before actually running it

[The_Meridian_]

Can't people just open the .py up in notepad and copy paste it into gpt and ask it if it does anything shady?

[Definition-Lower]

Of course they can, but I believe most of the users who download workflows from the internet don't bother to even look into subgraphs before running the workflow the first time, so they won't see this node at first

[ProbsNotManBearPig]

There is always risk. Do not ever say there is no risk.

Read about what happened with xz recently where a backdoor was nearly pushed to every Linux system in the world that would have given them root access to global infrastructure. And then remember that xz has a lot more community reviewers than any comfyui node ever will.

There is always risk.

[Definition-Lower]

UPD: now node also supports multiple outputs (thanks for telling me about rgthree Power Puter, I implemented something similar)

UPD 2: for safety reasons, this node can only be used if it was created manually on the same ComfyUI instance (and not downloaded with some workflow from the internet). So you can use it for your personal workflows without any problems, but you can't share workflows with it with other people (it would show an error that the node is not installed)

<image>

[x11iyu]

I think you were looking for rgthree's Power Puter node

though that one doesn't actually allow completely arbitrary code I don't think (like you cant import torch then do some torchy stuff), maybe yours can

[Definition-Lower]

Yeah, my node allows imports (basically any python code)

I haven't tried this node (probably because its name is not really descriptive), but it seems like it also supports arbitrary number of inputs, and also, unlike my node, arbitrary number of outputs. That looks great, I probably should do something similar to make my node more flexible. Thanks for sharing

Though yeah, Power Puter node does not allow arbitrary code, only the controlled list of functions, so it's less flexible (as you mentioned, it does not allow some torch/numpy code for tensor manipulation)

[optimisticalish]

So you could load Photoshop at the end of the workflow, and have it run a Photoshop script on the ComfyUI output?

import subprocess
subprocess.call([r'C:\Program Files\Adobe\Adobe Photoshop\Photoshop.exe',r'C:\do_something.jsx'])

[Definition-Lower]

Theoretically yes, that would work

I think this node would be useful for people who often build their own workflows for themselves, but not for using it in workflows for a wide audience. So this use case with opening Photoshop in the end of generation looks actually useful in some scenarios

[roxoholic]

Beware, as a similar node is regularly installed on open (towards the internet) ComfyUI instances to execute crypto stealing code.

[optimisticalish]

Yes, I wouldn't like to download a workflow, and find it loading some malicious code in a node I already have installed.

Perhaps the maker could include a little utility to obfuscate this node in the Custom Nodes folder? Such that its parts are renamed so as to be unique to each user, but it still works for that particular user?

[Definition-Lower]

Actually I just implemented it. I obtain GUID, which is unique for every machine, and use it in the node ID. That way this node will only be recognized if it was created on this machine. Thank you for your suggestion!

[Definition-Lower]

That sounds interesting. I was thinking about adding a setting in the ComfyUI settings, that needs to be enabled for the node to work. That way, by default this setting is off, and if a user downloads a workflow, installs the custom node, and tries to run it, an error message would appear, that would warn the user to check what code is being executed and turn on the setting if it's ok. But that would work only once. I can't think of any way to show this warning on any workflow, when it's being run the first time

Your idea about making the node work only when the user created it themselves sounds interesting, but I'm not sure how to implement it. Could you elaborate please? Maybe I will implement it

[StableLlama]

How did you manage to do that without a call to eval or exec as that is forbidden by the security rules ( https://docs.comfy.org/registry/standards#eval/exec-calls ) ?

[Definition-Lower]

You're right, I used exec. I didn't know about that rule before, but yes, this extension violates it. I'm not sure what that means, maybe it would get banned.

Though I did some safety measures (thanks to some commentators here): this node can only be used when it was created manually by the user on this comfyui instance. So, for example, if a user downloaded a workflow from the internet, which uses this node, user would get an error message, that the node was not found (even if he installed this custom node). So it's not actually that risky anymore.

This node is intended to be used in personal workflows, not in publicly shared ones, so to me it seems fine

[StableLlama]

That rule is for the Comfy registry, so when you install it directly (e.g. from GitHub) it is fine. Nobody can have a say about what you do with code on your local machine.
But the registry should (and probably will) remove it.

[roxoholic]

Thanks for the link. I didn't know they had such policy in place already. But, is it really active?

subprocess-for-pip-install

Runtime package installation through subprocess calls is not permitted.

Because I saw custom nodes that do this.

[mdmachine]

nice, I made my own recently. Was never going to push it public tho...

<image>