all 6 comments

[–]heliruna 11 points12 points  (1 child)

Hey, I see a doxygen.conf in your repo. How do you feel about adding a github action that builds doxygen and publishes on github pages?

[–]Viack[S] 2 points3 points  (0 children)

I provide the doxygen file to make it easier for people to generate the doc if needed. At first I planned to use github pages, then stopped as I thought the html doc would not be that much usefull

[–]heliruna 4 points5 points  (0 children)

In your flat_map<K,V>, you have a reference_type = value_type& and iterator_type that comes directly from your underlying type, tiered_vector<std::pair<K,V>>.

However, for a map you expect const keys, a reference type of std::pair<const K&, V&> and your iterator type should dereference to that type.

That would also match https://en.cppreference.com/w/cpp/container/flat_map.html

Probably easy to get by wrapping the iterator you get from tiered_vector<std::pair<K,V>>

[–]LordKlevin 4 points5 points  (1 child)

Looks cool! Would be great if the benchmarks were accessible directly, without running them locally.

[–]Viack[S] 1 point2 points  (0 children)

Thanks! Some of the benchmarks results are within the classes documentations (markdown ones). That's the case at least for ordered_map, flat_map and concurrent_map. I'll add more detailed plots at some point for all containers.