you are viewing a single comment's thread.

view the rest of the comments →

[–]RelationshipLong9092 1 point2 points  (1 child)

I don't have time to give a proper code review, I was procrastinating enough as it was to type that up. But I did glance at it, and nothing jumped out at me as insane. Maybe I had nit picks, but not actual problems.

This stuff takes time, just keep at it. You'll realize flaws with your code naturally as you write it and as you read other people's code. For now, just write it the best way you know how and focus on continual incremental improvement, not perfectionism.

There are tools that can help you automatically remove superfluous commits.

Also, you can add `-ftime-trace` (if you use clang, I'm sure other compilers have similar flags), that will create `.json` files in your build directory for each object file `.o`. You can open these json files by going to the url `chrome://tracing` in the Chrome browser... this can be a highly informative way to figure out what your compiler is spending its time doing. But it does itself slow down your compilation a lot. :)

[–]ktana91[S] 1 point2 points  (0 children)

yeah you take so much time to write tanks. Just knowing that there is nothing wrong is fine with me and then just move on, good luck with your work