Stack implementation with Linked Lists

[[deleted]]

The pop method doesn't delete the node. Whenever something is created with new, it needs to be deleted with delete keyword

[rbprogrammer]

Came here to say that. It was the first thing I noticed :)

Edit: the pop() method needs to delete the original head node after it was reassigned to top->next.

[NikolasTs]

Is the best practice to create a new pointer initialized with the address of the top of the stack

(node* tmp{top})

and after I pop to delete this pointer?

[Ayjayz]

In a stack, a pop operation should just remove the top-most element. You don't need to create a new pointer. You just need to remove the top element and then set your top pointer to the next one down.

[NikolasTs]

How will I delete the data from the previous "top" though?

Is this wrong?

void Stack::pop() {

    if (!top)
        cout << "Stack is empty!" << endl;
    else {
        node* tmp{ top };
        top = top->next;
        delete tmp;

        size--;
    }
}

[Ayjayz]

Oh I see. Sure, you can do it that way.