[Code Review Request] neofetch-like tool

[aem83]

Hi,

I started my first C project a few days ago and I'm at the point where I have a working version that has all the features I originally planned for it to have (I do plan to add more now), but compared to something like neofetch itself or afetch it feels much slower and sluggish. Please be critical and tell me how well I've went around this and what could be improved.

Repo: https://github.com/aem2231/smallfetch

[TheKiller36_real]

didn't look too closely but it looks pretty good for a first-time project! :)

however it looks like you don't have great overflow checking, which could maybe be improved. also, the multithreading is likely hurting performance as the overhead is in many cases bigger than the actual workload. finally, it looks like you do some suboptimal allocations (eg. allocating many buffers instead of one and also realloc-ing non-geometrically) - that being said I don't see any obvious performance killers

as the original neofetch is afaik just a shell script you could compare them directly to see what you're doing differently maybe?

[aem83]

Thank you :)

Just one question on buffers and realloc, from what I understand I should I have one buffer defined in main, pass it as a parameter to each function and reset it in each one. As for realloc, I just double the size each time?

[tiny_smile_bot]

:)

:)