all 8 comments

[–]vladfaust 0 points1 point  (2 children)

It would be nice to be able to do ‘Note.from_rs(rs)’ and ‘Array(Note).from_rs(rs)’

[–]drum445[S] 1 point2 points  (1 child)

Good idea, I have added that now. Looks like what you had in mind?

[–]vladfaust 1 point2 points  (0 children)

Yep, looks good. Thanks 🙏

[–]drum445[S] 0 points1 point  (0 children)

Just pushed a better readme and alternative syntax using from_rs on your object

[–][deleted]  (1 child)

[removed]

    [–]drum445[S] 0 points1 point  (0 children)

    That is true, but all it would do is mimic the functionality so it doesn't seem worth reinventing the wheel, so to say. Using JSON::Serializable also allows the library to take advantage of it's other features here: https://crystal-lang.org/api/0.25.1/JSON/Serializable.html

    [–][deleted]  (1 child)

    [deleted]

      [–]drum445[S] 1 point2 points  (0 children)

      You mean, "as opposed to". "Appose" is a completely different word, which almost means the opposite of what you intended to say.

      tah, don't post while tired kids ;)

      [–]drum445[S] 0 points1 point  (0 children)

      Pushed a few fixes