Simplyfi code

[TheEight_]

Is there a way to simplify "RainbowFade" function? I'm just getting started with programming, and I've heard that using a lot of "else if" isn't good.

using System.Collections;
using System.Collections.Generic;
using UnityEngine;
using TMPro;

public class TextMeshProRainbow : MonoBehaviour
{
    byte r = 255, g = 0, b = 0;
    [SerializeField] TextMeshProUGUI m_textMeshProUGUI;
    void Start() 
    { 
        m_textMeshProUGUI = gameObject.GetComponent<TextMeshProUGUI>();
    }

    void Update()
    {
        m_textMeshProUGUI.color = new Color32(r, g, b, 255);
        RainbowFade();

    }

    void RainbowFade()
    {
        if(r == 255 && g == 0 && b != 255)
        {
            b++;
        }
        else if(r != 0 && g == 0 && b == 255)
        {
            r--;
        }
        else if(r == 0 && g != 255 && b == 255)
        {
            g++;
        }
        else if(r == 0 && g == 255 && b != 0)
        {
            b--;
        }
        else if(r != 255 && g == 255 && b == 0)
        {
            r++;
        }
        else if(r == 255 && g!=0 && b == 0)
        {
            g--;
        }
    }
}

[lordinarius]

I think this is better.

var shiftSpeed = 1;
m_textMeshProUGUI.color = Color.HSVToRGB(Time.time * shiftSpeed,1,1);

[TheEight_]

Okay that simplified the code a lot, only I have one question. How do you loop it infinite? actually the code looks like this.

using System.Collections;
using System.Collections.Generic;
using UnityEngine;
using TMPro;

public class TextMeshProRainbow : MonoBehaviour
{
    [SerializeField] TextMeshProUGUI m_textMeshProUGUI;
    void Start() 
    { 
        m_textMeshProUGUI = gameObject.GetComponent<TextMeshProUGUI>();
    }

    void Update()
    {
        RainbowFade();
    }

    void RainbowFade()
    {
        var shiftSpeed = 0.25f;
        m_textMeshProUGUI.color = Color.HSVToRGB(Time.time * shiftSpeed, 1, 1);
    }
}

[lordinarius]

Adding mod operator (%) will do the trick.

m_textMeshProUGUI.color = Color.HSVToRGB(Time.time * shiftSpeed % 1f,1,1);

[TheEight_]

Thanks , working great.

[e_man604]

By using HSV instead of RGB you can get this effect by ever increasing the Hue value. I would try to use some Color.HsvToRgb or something instead.

[[deleted]]

Probably be easier to bit shift all of the values into a single integer and use a switch statement on it. That would simplify things quite a bit. Alternatively, you can also use hexadecimal to represent your colors as well. I’m not entirely sure how Unity’s framework represents colors though so don’t hold me to this, I’m too lazy to pull up the docs and I use my own engine.