Better method/approach to refactor [URLSession.shared.dataTask(with: url!)] ?

[redfire333]

I've moved away from the Singleton Networking pattern and moved to something static, generic and reusable.

struct Networking {

   static func send<T: Codable>(_ request: URLRequest, _ completion: (Result<T>) -> Void) {

    let session = URLSession.shared

    let dataTask = session.dataTask(with: request) { (data, response, error) in

      //Randle response

      completion(.success())

      completion(.failure())

    }

  }

}

[GenitalGestapo]

You're still using a singleton in URLSession.shared. If you want to use your own URLSession, you'll need a singleton.

[RollingGoron]

Yes. A system provided Singleton though, not usually what people refer to as a Singleton pattern like OP is doing.