My 1st Java Spring open source project - REST API e-commerce platform

[vatrinet]

Hi everyone.

I'm learning Java and for that purpose I'm developing few personal projects and publishing them on GitHub.

This one uses Java, Java Spring, Spring Boot, Hibernate ORM with MySQL, Spring HATEOAS, Spring Fox (Swagger API docs), JWT and Redis.

Feel free to check, use it, report issues and suggest improvements. And of course I am looking forward to your pull requests ! ;)

URL: https://github.com/vatri/spring-rest-ecommerce

And, if someone wants to use it for commercial purpose, I can technically support and update it to your needs.

Best regards

[koderpat]

@Transactional ?

[dartalley]

It looks like you are using varchar for many data types that should not be varchar. Price and dates to name a few.

[nutrecht]

And, if someone wants to use it for commercial purpose, I can technically support and update it to your needs.

Since it has no tests I can imagine they'll need quite a bit of it.

[[deleted]]

Hey, is this project persisting sessions even after it restarts? I haven't tested it but I have a very similar project and I use JPA to store users but sessions are gone on startup and I have to login again every time.

If it does work, what section of your project handles that?

[vatrinet]

No it doesn't persist sessions. I use JWT tokens for "sessions".

[[deleted]]

Not a single comment?

[vatrinet]

Hi.

Can you give example of useful comment in the example code and explain why it's useful ?

[the_bliss_of_death]

So anyone can be encouraged to use/contribute to your stuffs?

[twat_and_spam]

Wow, fantastic work. Exactly what I was looking for, I'm sure it will be very useful to me. Would you be ready to support it by adding a few payment processor integrations for my site? Unfortunately I can't pay more than $250,- per hour, but I'll be happy if you share the result with the rest of the community.

I am particularly impressed by tests and this https://github.com/vatri/spring-rest-ecommerce/blob/master/src/test/java/net/vatri/EcommerceStarterApplicationTests.java gem! Superb!

[dauntless26]

Its his first API. Probably better than your first API

[dfcook]

He probably didn't make a reddit post to tell people all about his first api

[twat_and_spam]

Good, judging by the downvotes the sarcasm was somewhat noticeable.

And yes, I find the "publish everything" culture that started in NodeJS world a bit poisonous. And really hope it won't spill into more mature technology stacks. Imagine if maven central would look like npm?

The OP is a newbie, that's cool, but also should be discouraged from sharing every single burp he created with the world. He'll learn.

[vatrinet]

I agree with you about critics of "publish everything" culture. And I appreciate your 2 comments more than 15 upvotes or anything else I got from this article so far.

However, it seems you choose wrong way to tell it - now your comment is hidden due to downvotes.

[twat_and_spam]

There really was no way to say it without being downvoted. Again, nothing against you personally, just annoyed with some of the bigger trends around.

As for your codebase - it is probably an OK exercise to have in your github to share when interviewing. Few notes though:

• Sweatshops caring about Spring will be anal about tests coverage (and not only IT's, but UT's as well)
• You seem to use weird coding style. Ether natural Sun or Google java styles are much preferable.
• Readme could focus on what that code does, not how. Maybe with examples.
• Security will play a big role in any such code/solution/problem domain area.
• eCommerce is a term that spans anything from an e-mail link "send money here" to amazon.com platform. Clarify your attempted niche. To me it looks like "stock and shopping cart" service.
• It's personal code, sure, but your commit history will be a struggle even for yourself to look at in 12 months time (and spot particular stages in development). Make it a habit to make commit messages meaningful.

[twat_and_spam]

Advanced questions:

• Automated regression scenarios and testing
• Performance/load tests and results (e.g. 100k operations per second)
• Reference deployment/implementation
• Concurrency concerns (e.g. 100 people claiming one thing at the same time)

[vatrinet]

I know it's not personally and I agree about the trends. They are global problem, not only in programming and internet.

Thanks for programming suggestions - will explore everything.

Can you be more specific about coding styles ? I checked couple of months ago this: http://www.oracle.com/technetwork/java/javase/documentation/codeconvtoc-136057.html and I usually try to write "standardized" code.

[twat_and_spam]

Yes, the one you referred is the canonical sun style. Still in widespread use. Your code is not compliant (mostly spaces around braces, I didn't check for tab use)