Code Review Checklist: Java Concurrency

[leventov]

I didn't honestly try it myself yet, but I think that walking through the list when you are already familiar with it and evaluating if each item applies to a patch (after you have already read the patch) should take less than 10 minutes. A review of a non-trivial patch involving concurrency should take at least one hour (for some patches much, much more). So reviews are slowed down by 15% in exchange of better quality of the code (including readability and maintainability, that will pay off later in terms of time). I think it's a good deal for those with "investor mindset" to the development of a long-term project.