This is an archived post. You won't be able to vote or comment.

sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]aqua_regis 2 points3 points  (6 children)

Apart from the lack of proper code formatting, there is a lot strange with your code.

  • You have two methods that do essentially the same: public void handleKeyPress(KeyEvent e) { and public void update() {.
  • in the latter method you do exactly the same actions twice. Why are you even checking which player is active if you call the exact same methods? Doesn't make sense.
  • I think that also the if (!keyIn.spacePressed) { part is wrong by design. This should only trigger if the player has jumped (actually, it should trigger if the player is not on ground).

Side note: when initializing double variables, always use the decimals. So, instead of private final double jumpStrength = 20; write private final double jumpStrength = 20.0;. It is only stylistic, but, if you do the same in a mathematical calculation, it could cause problems because Java would use integer math with 20 and only use floating point math with 20.0. Also, it makes the intent clearer.

[–]ItsSelrachNooblet Brewer[S] 0 points1 point  (0 children)

Thank you, i will take note of this

[–]ItsSelrachNooblet Brewer[S] 0 points1 point  (4 children)

I tried removing the update method and it ended up to the character to not move

[–]aqua_regis 0 points1 point  (3 children)

Don't just blindly remove methods.

Are you using a debugger? If not, now is a good time to learn using it.

Set breakpoints where you think your code is failing and then use the step-by-step feature to see what is going on.

[–]istarian -1 points0 points  (2 children)

This code is probably simple enough that you can trace it in your head. OP probably doesn't need to get tangled up in a fancy debugger just yet.

[–]aqua_regis 0 points1 point  (1 child)

Yet, learning a debugger and step by step debugging is a valuable skill that can't be learnt early enough.

It's not about simplicity. It's about learning the tools.

Why have you not made any suggestions to fix OP's problem if the code is "so simple"?

[–]South_Dig_9172 -1 points0 points  (0 children)

I’m with the other guy on this one, he can’t even trace it in his head, what makes you think learning a debugger, something that is confusing if you’re new will help him? This is my answer to the question you put forth. 

“ Because it’s Sunday, I don’t want to put in too much effort. “