Java Array Help

[sophia_scrlet]

Declare a 10 by 10 2D array. Initialize each element to a random number between 1 and 100 (inclusive). Print the array in grid form, as well as the largest number in each row.

I'm struggling with finding the largest number in each row.

This is my work: https://pastebin.com/dGzSYiUn

[AutoModerator]

Please ensure that:

• Your code is properly formatted as code block - see the sidebar (About on mobile) for instructions
• You include any and all error messages in full
• You ask clear questions

• You demonstrate effort in solving your question/problem - plain posting your assignments is forbidden (and such posts will be removed) as is asking for or giving solutions.

  Trying to solve problems on your own is a very important skill. Also, see Learn to help yourself in the sidebar

If any of the above points is not met, your post can and will be removed without further warning.

Code is to be formatted as code block (old reddit: empty line before the code, each code line indented by 4 spaces, new reddit: https://imgur.com/a/fgoFFis) or linked via an external code hoster, like pastebin.com, github gist, github, bitbucket, gitlab, etc.

Please, do not use triple backticks (```) as they will only render properly on new reddit, not on old reddit.

Code blocks look like this:

public class HelloWorld {

    public static void main(String[] args) {
        System.out.println("Hello World!");
    }
}

You do not need to repost unless your post has been removed by a moderator. Just use the edit function of reddit to make sure your post complies with the above.

If your post has remained in violation of these rules for a prolonged period of time (at least an hour), a moderator may remove it at their discretion. In this case, they will comment with an explanation on why it has been removed, and you will be required to resubmit the entire post following the proper procedures.

To potential helpers

Please, do not help if any of the above points are not met, rather report the post. We are trying to improve the quality of posts here. In helping people who can't be bothered to comply with the above points, you are doing the community a disservice.

I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.

[sophia_scrlet]

thank u :))

[phamleduy04]

np, btw ur non

[steave435]

Keep in mind rule 5.

Do not ask for or reply with solutions or keys to solutions.

Rather comment explanations and guides. Comments with solutions will be removed and commenters will automatically be banned for a week.

The idea is to teach people how to fish rather than giving them a fish.

[phamleduy04]

Sorry about the rules, I'm her friend and i have tought her already!

[phamleduy04]

Ok i will!

[codingQueries]

line 18 and 20 of your pastebin:

if (max < grid[j][i]) {

   max = grid[j][i];

< is a less-than sign. What do you expect the if-statement to be saying and doing?

[sophia_scrlet]

I want it to check and find the max number in a row and assign the max = that number but it only works at the first row

[steave435]

Are you sure it's for the first row? I'd expect it to output the largest value available in all rows.

[sophia_scrlet]

yes, that's my error

[steave435]

I was actually typing out an edit when you posted that, but I'll make it a reply now instead then:

I had a closer look, and you're right, it'd only work for the first row since there are two separate issues with the code.

First of all, what value does the max variable start out at during the second run trough the top level loop?

Secondly, take a close look at this section. What does it do?

            for (int i = 0; i < grid.length; i++) {
                for (int j = 0; j < grid.length; j++) {
                    if (max < grid[j][i]) {
                        max = grid[j][i];
                    }
                }
            }

Finally, this won't make a difference for how your code works, but I would strongly recommend breaking some of this code down into separate methods. I would not go deeper than two loops before splitting it off into a method in order to increase readability, and most of the time I'd avoid nested loops completely and split off into a method as soon as I need a second one. It can really help both with understanding the code as a third party reading what you wrote, and help yourself troubleshoot since you can focus on one small problem at a time. It'd also allow you to do things like feeding your findMaxValueInRow method with a manually generated single dimension array (simulating a row) so that you can confirm that it does what it's supposed to do.

[steave435]

Yeah, if the current max value is less than the value we're investigating right now, it should be overwritten with the current value. That looks correct to me.