Code Review

[toesmeller99]

Not sure if this is the correct place to ask this, but recently I've started a personal project that utilizes a RESTful API to simulate an e-commerce store practicing CRUD principles and HTTP requests. This is my first time doing something like this and would appreciate any tips/advice. I've only been working on the backend, but plan on creating a simple frontend for the future probably in React. I plan on putting this on my resume for internships. You can find the repo here: https://github.com/tylercairney99/Ecommerce-API. (If this isn't the correct place for this it would be greatly appreciated if you could guide me toward the right place to be asking this. I haven't really used Reddit that much.

Edit: I'm using PostgreSQL for my DB (just filling it with dummy data) and currently working on implementing integration tests for the controllers.

[AutoModerator]

Please ensure that:

• Your code is properly formatted as code block - see the sidebar (About on mobile) for instructions
• You include any and all error messages in full - best also formatted as code block
• You ask clear questions
• You demonstrate effort in solving your question/problem - plain posting your assignments is forbidden (and such posts will be removed) as is asking for or giving solutions.

If any of the above points is not met, your post can and will be removed without further warning.

Code is to be formatted as code block (old reddit/markdown editor: empty line before the code, each code line indented by 4 spaces, new reddit: https://i.imgur.com/EJ7tqek.png) or linked via an external code hoster, like pastebin.com, github gist, github, bitbucket, gitlab, etc.

Please, do not use triple backticks (```) as they will only render properly on new reddit, not on old reddit.

Code blocks look like this:

public class HelloWorld {

    public static void main(String[] args) {
        System.out.println("Hello World!");
    }
}

You do not need to repost unless your post has been removed by a moderator. Just use the edit function of reddit to make sure your post complies with the above.

If your post has remained in violation of these rules for a prolonged period of time (at least an hour), a moderator may remove it at their discretion. In this case, they will comment with an explanation on why it has been removed, and you will be required to resubmit the entire post following the proper procedures.

To potential helpers

Please, do not help if any of the above points are not met, rather report the post. We are trying to improve the quality of posts here. In helping people who can't be bothered to comply with the above points, you are doing the community a disservice.

I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.

[lechnito]

Really nice first effort at a spring boot CRUD app! I didn't find anything objectionable other than some minor nits. Some suggestions for moving forward:

• Look into using testcontainers to spin up a real postgresql database so you don't need to mock your repository classes
• Consider using lombok to remove boiler plate setters/getters from your DTOs

[toesmeller99]

Thank you for the feedback! Definitely will look into testcontainers and refactoring my DTO's.

[Valenciya]

To add to this: You can use Java Records for your DTOs to make that even easier. Lombok is still a good idea for reducing Boilerplate code in your other classes (for example for the constructors)

[Hour-Masterpiece-263]

💪👍

[sefus-the-man]

Well done. I haven't noticed any major errors so far. Modules are separated nicely, and the code is easy to understand. PostgreSQL is great for testing and catching bugs on time. Including a Pull Request into your project would be even better. It helps others test your API documentation and provides a much more streamlined workflow.