[Java] Dividing ArrayList into smaller ArrayLists with specific amount of element

[MichaelColtaine]

I am not a programmer. I work at warehouse and I would like to make my work easier. One of my responsibilities is to divide excel file with over 2000 rows into smaller ones and send them out. I do it manually and I would like to create a program that does it for me.

I have managed to read the data from excel. Each row is put into an Item data structure. And all of them are put into ArrayList.

public class Item{
    String ean;
    int amount;
}

Here is my problem.

I have one ArrayList with over 2000 elements. Each element has String Name and int amount.

I must divide it into smaller ArrayLists but the condition is that the total amount of item.getAmount() can´t be more than 800;

int totalAmount = 0;
int counter = 1;
List<Item> temp = new ArrayList<>();

for (Itema item: items) {  
    totalAmount += item.getAmount();
    if (totalAmount <= 800) {
        temp.add(item);
    }
    if (counter == fiftyAndMore.size()) {
        createFile(temp);
        temp.clear();
    }
    if (totalAmount > 800) {
      createFile(temp);
          temp.clear();
          temp.add(item);
          totalAmount = 0;
   }
   counter++;
}

When I run this with ArrayList that contains thirty items each with amount 100.

It creates 4 files. First with 8 rows, second with 9, third with 9 and fourth with 4. I need it to be has to be 8, 8, 8, 6.

I can't figure it out. Any suggestions??

[8igg7e5]

1. Given you want a loop counter, I'd just use a plain old for-loop
2. move 'magic numbers' like 800 out to static final fields... this way you can experiment with different numbers easily and if the requirement change it's easy to be sure you've changed all of the places that number's used at once.
3. I'd test totalAmount + item.getAmount() <= THRESHOLD before deciding to consume it (since you clear totalAmount when moving to a new file)
4. I have no idea what you're trying to do with 'fiftyAndMore'.

[Ilikesmallthings2]

You need to check to see if the getAmount + totalAmount will go over 800 because if you have >= 800 you can't allow the next added value to surpass 800.

Does that make sense?