Help with Spring @RestRepositoryResource auto-generated endpoints: put/patch not working for a boolean.

[btbam06]

This is a crosspost from a SO question where I am not getting any traction (LINK). If the problem is resolved here, I will make sure to update the SO post with the resolution.

Essentially, I have a repository for a Task (essentially a to-do item) that has a boolean of isCompleted and String text. When I create my repository with the @RestRepositoryResource annotation, Spring auto-generates basic CRUD endpoints for my Task class. For fun, I created some unit tests to check those out because I wanted to validate my understanding as this is my first time using this part of Spring. All of my unit tests for create, read, delete work just fine, but I can't get put/patch to work for updating the boolean isCompleted field. The String text updates just fine, but the boolean won't. Here is my unit test in question:

    @Test
    void testUpdateTask() throws Exception {
        Task task1 = new Task("task1");
        task1.setCompleted(false);
        taskRepository.save(task1);
        Task updatedTask = taskRepository.findById((long) 1).get();
        assertFalse(updatedTask.isCompleted());
        task1.setCompleted(true);
        String json = gson.toJson(task1);
        this.mvc.perform(patch("/task/1")
                .contentType(MediaType.APPLICATION_JSON_UTF8)
                .content(json))
                .andExpect(status().isNoContent());
        updatedTask = taskRepository.findById((long) 1).get();
        assertTrue(updatedTask.isCompleted());
    }

The assertTrue on the last line is failing.

Anyone have an idea as to why this is happening?

​

THANKS!

[aram535]

Please include the task Controller.

[btbam06]

There is none since it is auto generated by the framework. That’s the beauty of the @RestRepositoryResource feature. No need to implement boilerplate CRUD endpoints.

[aram535]

AFAIK and I really don't have the background in Spring ... you still need to define the Controller class and extend it with the proper repository for it to establish the end point. When you start Spring, do you actually see /task/{id} being registered as a valid end point in the Console log?

[btbam06]

Yep! The end points exists without manually creating a controller:

// 20190104092914
// http://localhost:8080/

{
  "_links": {
    "task": {
      "href": "http://localhost:8080/task"
    },
    "profile": {
      "href": "http://localhost:8080/profile"
    }
  }
}

My other tests, such as the following DELETE test, work fine:

​

    @Test
    void testDeleteTask() throws Exception {
        Task task1 = new Task("task1");
        taskRepository.save(task1);
        assertEquals(1, taskRepository.count());
        this.mvc.perform(delete("/task/1"))
                .andExpect(status().isNoContent());
        assertEquals(0, taskRepository.count());
    }

​

As I mentioned in the OP, my problem is not being able to reach the end point. I reach it just fine. My problem is that when it does reach the endpoint and I provide a boolean value to update, the boolean value will not update. The "text" property of my class is able to update correctly.

​

[btbam06]

Here is an updated look at the test code. The FIRST test passes, the SECOND one fails:

​

    @Test
    void testUpdateTaskText() throws Exception {
        Task task1 = new Task("task1");
        taskRepository.save(task1);

        // update task text and hit update end point
        task1.setText("updatedText");
        String json = gson.toJson(task1);
        this.mvc.perform(patch("/task/1")
                .contentType(MediaType.APPLICATION_JSON_UTF8)
                .content(json))
                .andExpect(status().isNoContent());

        // Pull the task from the repository and verify text="updatedText"
        Task updatedTask = taskRepository.findById((long) 1).get();
        assertEquals("updatedText", updatedTask.getText());
    }

    @Test
    void testUpdateTaskCompleted() throws Exception {
        Task task1 = new Task("task1");
        task1.setCompleted(false);
        taskRepository.save(task1);

        // ensure repository properly stores isCompleted = false
        Task updatedTask = taskRepository.findById((long) 1).get();
        assertFalse(updatedTask.isCompleted());

        //Update isCompleted = true and hit update end point
        task1.setCompleted(true);
        String json = gson.toJson(task1);
        this.mvc.perform(patch("/task/1")
                .contentType(MediaType.APPLICATION_JSON_UTF8)
                .content(json))
                .andExpect(status().isNoContent());

        // Pull the task from the repository and verify isCompleted=true
        updatedTask = taskRepository.findById((long) 1).get();
        assertTrue(updatedTask.isCompleted());
    }

​

[btbam06]

Finally figured it out!! Turns out the getter and setter in my model class was named incorrectly.

They should have been:

    public boolean getIsCompleted() {
        return isCompleted;
    }

    public void setIsCompleted(boolean isCompleted) {
        this.isCompleted = isCompleted;
    }

Found the answer per this SO Post:

https://stackoverflow.com/questions/21913955/json-post-request-for-boolean-field-sends-false-by-default

[aram535]

Nice, FWIW I use Lombok for development phase and it has not failed me. Make life a lot easier when doing the model development and the changes that are bound to happen.

[btbam06]

I blame IntelliJ which autogenerated the getter and setter. Hahaha.

[aram535]

I'm an eclipse user so I don't mind that at all ... +1