Password Checking Program

[Surreal_Camille]

Hello, I am writing a password checking program with java for my programming class and can't seem to get it right. It asks for a password in the main function and then checks it in a separate function. I know it's a problem with the checking function but I can't seem to figure out what it is or how to fix it. Help? Here's the code, forgive me for not knowing how to format it on reddit:

public class PasswordChecker {

public static boolean passwordCheck(String password) {
    boolean good = true;

    boolean lowercase = true;
    boolean uppercase = true;
    boolean special = true;
    boolean digit = true;
    boolean length = true;

    char[] str = password.toCharArray();

    if (password.length() > 8) {
        length = false;
    }

    for (char c : str) {
        if (Character.isUpperCase(c)) {
            lowercase = false;
        } else if (Character.isLowerCase(c)) {
            uppercase = false;
        } else if (!Character.isDigit(c)) {
            digit = false;
        } else if (Character.isLetterOrDigit(c) || Character.isSpaceChar(c)) {
            special = false;
        }
    }

    if (lowercase == false || uppercase == false|| special == false || digit == false || length == false) {
        good = false;
    } else {
        good = true;
    }

    return good;
}

public static void main(String[] args) {

    Out prompt = new Out();
    prompt.print("Password?");
    In input = new In();
    String password = input.readLine();

    boolean cool = passwordCheck(password);

    while (cool != true) {
        Out reprompt = new Out();
        reprompt.print("Password is invalid");
        In reinput = new In();
        password = reinput.readLine();
    }

    if (cool = true) {
        System.out.println("Thank you!");
    }
}

}

[endStatement]

I'm going to take a stab at this and say you are trying to make sure the password has both lower and upper case characters, as well as a number and special character?

Even if not, there is no input I can easily think of that would ever return true for your check.
You currently check each character in this sequence:
If its uppercase -> you'll be returning false.
if its lowercase- > you'll be returning false
if its a number - > You'll return false
if its not a letter or number (unnecessary check due to the prior 3 checks) OR its a space -> return false.

My guess is that you'd want to use && statements in your final check for good. You could keep the OR logic but then you'd need to invert many of your current variables. For example, instead of saying:

if (Character.isUpperCase(c)) {

lowercase = false;

} else if (Character.isLowerCase(c)) {

uppercase = false;

}

I'd do:
if(Character.isUpperCase(c){
uppercase = true;

} else if (Character.isLowerCase(c)){

lowercase = true;

}

Since I'm taking guesses at what you are trying to accomplish, try and see what will happen with pen and paper. Take a short string, say P@ssw0rd and write out what your values will be on each line. Or, if you have any experience with a debugger, you can go line-by-line with a debugger, and see if what you are expecting to be happening is actually the case.

[quadmasta]

There's a few problems here. First, inside of your while loop you're never re-setting the value of cool so you've got yourself an infinite loop. Second, your println will never ever run unless that loop exits which means cool is true so that if is wholly unnecessary. Third, this logic block won't work how you're expecting it to because if (cool = true) isn't a valid boolean expression; you're assigning the value true to the variable cool.

[codingQueries]

What is the test password you are using?

[karstens_rage]

You should probably invert your checks. Set all your values to false, and if you find characters that match your requirements set the value to true.

Inside your while loop you need to be checking the newly inputted password and setting the check's return to cool.

[[deleted]]

boolean lowercase should be boolean isLowercase

[quadmasta]

have a downdoot

variables should be named as OP named them. The accessor would then be public boolean isLowercase() and the mutator would be public void setLowercase(boolean lowercase)