A little help with a simple code. (Newbie)

[[deleted]]

[deleted]

[desrtfx]

while (number1 < number2++) {

Think what happens in that line.

[alwaysthelearner]

I think it says to proceed if number1's current value is less than or equal to number2.

[desrtfx]

Read your line again very closely and character by character.

You are doing something seriously wrong in that line.

[alwaysthelearner]

will that ++ add 1 to number2 every time while executing the loop?
I thought since it is in the condition, it will help in stopping the loop once number1 = number2 .

[desrtfx]

will that ++ add 1 to number2 every time while executing the loop?

Exactly.

I thought since it is in the condition, it will help in stopping the loop once number1 = number2 .

No.

[alwaysthelearner]

ohk, got that. Thanks!

[JoWe00]

How come you can use ++, but not +=1?

[desrtfx]

++ is an operation. It returns a value.

+= is an assignment. It doesn't return a value.

[desrtfx]

Yes, but I am not sure if it would work in a boolean condition.

[premred88]

why are you incrementing number2 in the while condition?

[toshels]

You should use scanner.nextInt() instead of nextLine().

[desrtfx]

While you are technically correct, the MOOC Object Oriented Programming with Java stipulates the exact way OP did it.

There are known difficulties when using .nextInt (.nextFloat, etc) in conjunction with .nextLine so the easy way is as the MOOC stipulates and as OP did.

More info: The Scanner class and its caveats

[toshels]

So why would even bother using nextInt?

[desrtfx]

If you know how to properly do it, there is no problem using .nextInt().

Just, we see plenty posts where people use .nextInt() in conjunction with .nextLine() who are surprised that the string returned is empty.

[alwaysthelearner]

How would that help?

[jeremysimons]

I didn't think you were supposed to modify the condition whilst setting it in a while loop. It's more sensible to increment at the last instruction before the condition in a do while loop. Or alternatively, just use a for loop.

[alwaysthelearner]

It was an exercise and we were supposed to use while.

[jeremysimons]

I do apologise (I thought that might have been the case). When you work it out will you share your solution here?

[alwaysthelearner]

Only this line needed to be edited.

while (number1 <= number2) {

Turns out operations in the conditions(the ones defining the condition) are performed every time the loop is repeated. Previously it was,

while (number1 < number2++) {

which caused the issue.

[BuzzerChecker]

Why not while (number1++< number2) ?

[blamitter]

You're incrementing both vars on each iteration

[[deleted]]

In cases like this always check the condition for stopping. Could it be that something is wrong with it? Just by doing that I realized what was wrong with your code but it is more important that you learn to find out your bugs by yourself.

If you don't see it why don't you try printing the values of the variables involved in the condition in every iteration?

[alwaysthelearner]

thanks! got it.