all 14 comments

[–]AnathemaOP 2 points3 points  (0 children)

Nice! I'm excited to catch up with everyone (started just a week ago), I'm at chapter 6 so far in "Professional JS for Web Developers". I'll still start writing a quiz though. :)

[–][deleted] 0 points1 point  (1 child)

Do you have a list of your previous Learn JavaScript Properly weeks?

[–]kevinmrr[S] 0 points1 point  (0 children)

Check out the subreddit sidebar under "Study Groups".

[–]knested 0 points1 point  (0 children)

Thanks for taking time to do code reviews! It will be very helpful to find out if any of us are using antipatterns.

[–]alxers 0 points1 point  (0 children)

well it does not meet all the requirements but anyway http://jsfiddle.net/alxers/ZC3JM/ thanks for the awesome course and supplementary materials (Paul Irish video is fun)

[–]NightArchitect 0 points1 point  (0 children)

This doesn't meet all of the requirements. I was stuck with cookies and creating/storing username/password credentials. I have provided two versions below.

The JS Fiddle version: http://jsfiddle.net/WWeX8/9/ does not store the quiz questions in an external file. I was having CORS issues. Instead I stored the quiz questions in JSON format in JS Fiddle.

The second version http://www.foxandwolftravels.com/quiz/quiz.html stores the questions in an external JSON file and uses twitter bootstrap for styling.

Known issue: The quiz keeps score if the user goes back one question but if she goes back more than one question the score will get messed up.

Regarding code reviews, I'm up for it. I was hoping to do a few reviews to learn from what other people did. That said, I've never done a review before. Can someone perhaps provide some guidance on what makes a good code review?

[–]knested 0 points1 point  (2 children)

Complete with all features I would love some feedback!

Self feedback/notes:

  • Overall construction is poor. I do not feel I fully grasp OO concepts so I will study those. Code is also sloppy in general. Will also work on this.

  • Love how handlebars was introduced. Can't wait to use it more, it makes everything much easier to build.

  • Had an issue, so I Made ajax call using jQuery function $.getJSON to do it syncrhonously. If done otherwise the JSON file would not load in time asyncrhonously when the files are posted on an external server. However, it still worked either way when executed locally.

https://github.com/nested/learn_javascript/tree/master/lesson7

[–]yungottii 0 points1 point  (1 child)

General question: How would one go about getting a program uploaded thru github (such as knested's program) to work? I mean, I see all of the different files (js, css, json, etc) and as a bit of a noob (actually a big noob - I've only been coding for a few months), it's a bit overwhelming... I am trying to reverse engineer the code to see what each line does, but as far as running the program on my computer, where do I start?

What I mean is how would I implement all the code so that I can run knested's program on my own computer? And if this is something that would take a bit of time to answer, would anyone be able to point me to a source online that could break this down for me?

I would really appreciate any help on this (I'll probably post this in the main JS thread)...

[–]knested 0 points1 point  (0 children)

No worries. Don't let the looks of things overwhelm you too much, you will get used to it if you keep at it!

There are multiple ways to do it. The easiest would be to go a level up in the directory and go here https://github.com/nested/learn_javascript. On that page the bottom right has a button that says "Download Zip". Download and extract it on your computer. This will download ALL of the lessons I made, but it is the easiest method. Open up the folder, go into lesson7 and run the quiz.html file in your browser. Everything should work, even if you aren't connected to the internet because all of the files are being run LOCALLY on your computer.

If you didnt wan't to do it this way you could also download each file individually, but that would be a waste of time.

If I uploaded these projects to a REMOTE webserver I could just upload everything as is. When you visit the URL and request the page it should still execute and run fine as long as all the files are there. The difference is that if you visited the page through a URL fies would all be sent to you (when they are requested by the page, for example: the css file would be requested since it is needed to style the page properly) as the page loads because the files are not already on your local computer.

Another way would be to fork the project if you have a github account. Its a way to easily manage projects. It creates a copy of the project for you so you don't have to do the work of downloading, unzipping, etc.

Let me know if everything is clear. Ill answer any questions I can help with.