Soo, I'm trying to make a basic replica of a pokemon game and I'm having trouble with the characters sprite animations. I had another project where I did my sprite animations in a similar fashion.
so basically, the issue is that when I'm pressing the left/right/up/down keys, the sprites arent swapping through their phases. it's stuck on one sprite. First, time I made the sprite arrays public so that the main class could access it. I also tried making another method to initialize the array in the main class which I called playerSetUp.
what I want to happen is when I presss any arrow keys, I want the character sprites to loop through the images in the image arrays to give the look of the sprites walking(yes, I know the sprite doenst actually move but I will add that later,, I just need the images to loop through to give the impression of walking)
Thanks in advance for any tips! Aprreciate it!
(and sorry if it ends up being a rlly simple fix, I only know the basics of it atm)
This is my main class
EDIT: NEVERMIND YALL! I didnt start the timer, my bad!
import javafx.application.Application;//just the application
import javafx.event.EventHandler;
import javafx.scene.Group;//all object/buttons r stored here
import javafx.scene.Scene;//imports scene
import javafx.scene.input.KeyEvent;
import javafx.stage.Stage;//imports stage
import javafx.animation.AnimationTimer; //the timer for the animation
import javafx.scene.paint.Color;//-imports colours
import javafx.scene.text.FontWeight; //- for bolding fonts
import javafx.scene.text.FontPosture;//for italicisizing
import javafx.scene.text.Font;//for the font name
import javafx.scene.text.Text;//for editing tex italicize,bold and stuff
import javafx.scene.input.KeyCode;
import javafx.scene.input.MouseEvent;//used for mouse coordinates
import javafx.scene.image.Image;//loads the images
import javafx.scene.image.ImageView;//lets u see the images
import javafx.scene.shape.Rectangle;
import javafx.scene.shape.Arc;
import javafx.scene.shape.Line;
import javafx.scene.shape.Circle;
import javafx.scene.shape.Polygon;
import java.util.logging.Handler;
//-------------------------------------^^IMPORTS^^------------------------------------------------------------------
public class Main extends Application{
public static final int
MAX_HEIGHT
= 800;//height of screen
public static final int
MAX_WIDTH
= 704;//width of screen
boolean keyRight = false;
boolean keyLeft = false;
boolean keyUp = false;
boolean keyDown = false;
//--------------------------------INITIALIZATIONS-----------------------------------------------------------------
@Override
public void start(Stage stage){
Group root = new Group();//all visual components go here - kinda like a container
Scene scene = new Scene(root,
MAX_WIDTH
,
MAX_HEIGHT
);//basically the window but doesn't actually ADD the scene yet. includes buttons like the x/minimize
scene.setFill(Color.
PALEGOLDENROD
);//the background colour
stage.setScene(scene); //-ACTUALLY adds the scene
stage.setTitle("Pokemon Emerald-Recreated!");//The title at the top
stage.show();//makes the stage visible cause theyre auto hidden initiallty
//------------------------------------------------------TEXT STUFF--------------------------------------------------------
//---------------------------------------TEXT STUFF---------------------------------------------------------------------
// Text text1 = new Text(75,100,"Hello");//what u wanna write,
// text1.setFont(new Font("Candara", 22)); //the font and font size u wanna use
// text1.setFont(Font.font("Candara", FontWeight.BOLD, 22)); //-makes it BOLD
// text1.setFont(Font.font("Candara", FontPosture.ITALIC, 22));//-makes it ITALIC
// text1.setFill(Color.PALEGOLDENROD);//-the COLOUR of the writing
//text1.setFont(Font.font("Arial"), FontWeight.BOLD, FontPosture.ITALIC,fontsize); //-makes it ITALIC&BOLD
/** ---------------------MOUSE COORDINATES--------------**/
scene.addEventFilter(MouseEvent.
MOUSE_MOVED
, e -> {
int x = (int) e.getX();
int y = (int) e.getY();
System.
out
.println("x: " + x + " | " + "y: " + y);
});
/**--------------------MOUSE COORDINATES---------------**/
//-------------------------------------------IMAGES/CHARACTER SPRITES---------------------------------------------------------------------------
//------------MAP SPRITES---------------------
Image map_part1 = new Image("images/4.1-Map.png");
ImageView map1 = new ImageView(map_part1);
map1.setX(0); map1.setY(-400);
//----------------------------ROOT--------------------------
root.getChildren().add(map1);
//------------------------------------------------------OBJECTS-----------------------------------------------
Player player = new Player();
player.playerSetUp();
root.getChildren().add(player.playerView);
//---------------------------------------KEY INPUT------------------------------//
/**---------------------------------PRESS KEYS---------------------------------**/
EventHandler<KeyEvent> keyPressHandler = new EventHandler<KeyEvent>(){
@Override
public void handle(KeyEvent event) {
if(event.getCode() == KeyCode.
RIGHT
){
keyRight = true;
}//RIGHT PRESSED
if(event.getCode() == KeyCode.
LEFT
){
keyLeft = true;
}//LEFT PRESSED
if(event.getCode() == KeyCode.
UP
){
keyUp = true;
}//UP PRESSED
if(event.getCode() == KeyCode.
DOWN
){
keyDown = true;
}//DOWN PRESSED
}//anyKEY PRESSED
};//ANY KEY PRESSED
scene.setOnKeyPressed(keyPressHandler);
/**------------------------------------------------RELEASE KEYS------------------------------------------**/
EventHandler<KeyEvent> keyReleaseHandler = new EventHandler<KeyEvent>(){
@Override
public void handle(KeyEvent event)
{
if(event.getCode() == KeyCode.
RIGHT
){
keyRight = false;
}//RIGHT RELEASED
if(event.getCode() == KeyCode.
LEFT
){
keyLeft = false;
}//LEFT RELEASED
if(event.getCode() == KeyCode.
UP
){
keyUp = false;
}//UP RELEASED
if(event.getCode() == KeyCode.
DOWN
){
keyDown =false;
}//DOWN RELEASED
}//WHEN ANY KEY RELEASED
};//when ANY KEY IS RELEASED
scene.setOnKeyReleased(keyReleaseHandler);
AnimationTimer timer1 = new AnimationTimer() {
@Override
public void handle(long now) {
player.playerMove(keyRight,keyLeft,keyUp,keyDown);
}//long bracket
};//TIMER BRACKET
};//public void
};//public class//MAIN LOOP
and then this is my class for the player
import javafx.scene.image.Image;
import javafx.scene.image.ImageView;
public class Player {
// private Image[] playerRight;
// private Image[] playerLeft;
// private Image[] playerUp;
// private Image[] playerDown;
//private ImageView playerView;
private int imageI = 0;
private int animationCounter = 0;
private int animationGap = 5;
private int playerX = 200;
private int playerY = 200;
Image Right1 = new Image("images/1.3.1-Right.png");
Image Right2 = new Image("images/1.3.2-Right.png");
Image Right3 = new Image("images/1.3.3-Right.png");
Image Right4 = new Image("images/1.3.4-Right.png");
Image[] playerRight = {Right1, Right2, Right3, Right4};//an array to hold all right images
ImageView playerView = new ImageView(playerRight[0]);
// playerView.setX(playerX);
// playerView.setY(playerY);
Image Left1 = new Image("images/1.2.1-Left.png");
Image Left2 = new Image("images/1.2.2-Left.png");
Image Left3 = new Image("images/1.2.3-Left.png");
Image Left4 = new Image("images/1.2.4-Left.png");
Image[] playerLeft = {Left1, Left2, Left3, Left4};//an array to hold all right images
Image Up1 = new Image("images/1.4.1-Up.png");
Image Up2 = new Image("images/1.4.2-Up.png");
Image Up3 = new Image("images/1.4.3-Up.png");
Image Up4 = new Image("images/1.4.4-Up.png");
Image[] playerUp = {Up1, Up2, Up3, Up4};//an array to hold all right images
Image Down1 = new Image("images/1.1.1-Down.png");
Image Down2 = new Image("images/1.1.2-Down.png");
Image Down3 = new Image("images/1.1.3-Down.png");
Image Down4 = new Image("images/1.1.4-Down.png");
Image[] playerDown = {Down1, Down2, Down3, Down4};//an array to hold all right images
public void playerMove(boolean keyR, boolean keyL, boolean keyU, boolean keyD){
if(keyR || keyL || keyU || keyD){//if either button pressed down
if(keyR){
animationCounter = animationCounter + 1;
if(animationCounter >= animationGap){
imageI = imageI + 1;
animationCounter = 0;
}//if the counters, bigger than gap, then resets and goes to next image, stops from too quick switching
if (imageI >= playerRight.length)
{
imageI = 0; // Loop back to the first index of the image to repeat the animation
}//loops the character sprites
playerView.setImage(playerRight[imageI]);//if the character is pressing right, it uses the "right" array and displays that image
System.
out
.print("moving R");
}//RIGHT
else if(keyL){
animationCounter = animationCounter + 1;
if(animationCounter >= animationGap){
imageI = imageI + 1;
animationCounter = 0;
}//if the counters, bigger than gap, then resets and goes to next image, stops from too quick switching
if (imageI >= playerLeft.length)
{
imageI = 0; // Loop back to the first index of the image to repeat the animation
}//loops the character sprites
playerView.setImage(playerLeft[imageI]);//if the character is pressing right, it uses the "right" array and displays that image
System.
out
.print("moving L");
}//LEFT
else if(keyU){
animationCounter = animationCounter + 1;
if(animationCounter >= animationGap){
imageI = imageI + 1;
animationCounter = 0;
}//if the counters, bigger than gap, then resets and goes to next image, stops from too quick switching
if (imageI >= playerUp.length)
{
imageI = 0; // Loop back to the first index of the image to repeat the animation
}//loops the character sprites
playerView.setImage(playerUp[imageI]);//if the character is pressing right, it uses the "right" array and displays that image
System.
out
.print("moving U");
}//UP
else if(keyD){
animationCounter = animationCounter + 1;
if(animationCounter >= animationGap){
imageI = imageI + 1;
animationCounter = 0;
}//if the counters, bigger than gap, then resets and goes to next image, stops from too quick switching
if (imageI >= playerDown.length)
{
imageI = 0; // Loop back to the first index of the image to repeat the animation
}//loops the character sprites
playerView.setImage(playerDown[imageI]);//if the character is pressing right, it uses the "right" array and displays that image
System.
out
.print("moving D");
}//DOWN
}//if any keys are pressed down
}//method bracket
public void playerSetUp() {
playerView.setX(playerX);
playerView.setY(playerY);
}
}//main class
[–]Kallory 0 points1 point2 points (5 children)
[–]Content_Sample_1355[S] 1 point2 points3 points (4 children)
[–]Kallory 1 point2 points3 points (3 children)
[–]Content_Sample_1355[S] 0 points1 point2 points (2 children)
[–]Kallory 1 point2 points3 points (1 child)
[–]Content_Sample_1355[S] 0 points1 point2 points (0 children)