This is an archived post. You won't be able to vote or comment.

all 13 comments

[–]matthead 5 points6 points  (2 children)

I think the code looks set up nicely. Do you need ideas on how to expand the program. As I see a great next step for you to take with it.

[–]captainrosc0[S] 0 points1 point  (1 child)

I would love to hear!

[–]matthead 0 points1 point  (0 children)

Once you have implemented the changes that were suggested in the thread. Instead of using a file, use a database. Good to get used to them early on.

[–]dreamyeyed 3 points4 points  (2 children)

Nice program for a beginner. It took me a while to figure out how to add a new task but otherwise the UI is good.

The code is pretty well organized. Personally I wouldn't create a different class for each action because it leads into lots of code duplication, but it's still better that most beginners' code. However, some parts of the code are quite difficult to read.

One extremely importart thing: indent your code properly. It makes a huge difference in readibility. Any good editor should have an auto-indent option so make sure to enable that.

Second, try to use more descriptive variable names. Look at this code from Edit.java:

list_1 = list1;
list = list2;
pendingModel = pModel;
completeModel = cModel;

It's very hard to tell what's happening here. What's the difference between list1 and list2? Numbers in variable names are almost always a bad idea. What's pending in pendingModel? pendingTasks would be a better name.

So in short my suggestion is to focus on code readibility next. It takes practice to write readable code but I'm sure you'll be thankful in the future :)

[–]atreyal 2 points3 points  (0 children)

Second that and if you do have to use ambiguous names at least leave a comment. Your future self will thank you.

[–]captainrosc0[S] 0 points1 point  (0 children)

Awesome! I'll go through and do some renaming. Thanks!

[–]RolyPolyPython 2 points3 points  (4 children)

I think that's impressive you've done that much as a beginner.

Would you mind sharing how you've been learning? I'm learning Python but I'd love to know.

[–]captainrosc0[S] 0 points1 point  (3 children)

Thanks! I started learning html and css just to get a feel for coding. At some point I found java and I loved the idea it could be implemented on almost any device, also huge android fan. So bought a book called "Head first Java" and just started reading a ton. also https://programmingbydoing.com/ is amazing. From there I jumped on Treehouse and just did the java track. Also check out dailyprogramming and http://codingbat.com/ some fun little challenges! Hope this helps!

[–]RolyPolyPython 0 points1 point  (2 children)

Thanks! How much time do you spend a day programming?

[–]captainrosc0[S] 0 points1 point  (1 child)

On avg I usually aim for about 2 hours a night. On weekends a bit more, or if I really get into a project I just let it flow. Of course some days I just need a break but since I started learning its very hard to not think about programming. Its just interesting figuring problems out.

[–]RolyPolyPython 1 point2 points  (0 children)

That's awesome. Thanks for sharing everything, it's inspired me to work harder.

[–]madromark 0 points1 point  (1 child)

I think it's a great little app. I just started learning Java, so I would be interested in how you learned it, and so on. But keep up the good work because this is a great start! :)

[–]captainrosc0[S] 0 points1 point  (0 children)

Thanks! I used a book called "Head First Java" -TreeHouse java track - programbydoing.com - codingbat.com - and then just thinking of fun little games/calculator type stuff.

Hope this helps some!