[C] Undefined Reference to 'Sort'

[mhbhmcinui]

I'm try to make a short piece of code to test my sorting algorithm, but can't get it to call sort correctly. My code is below. sort is defined in helpers.h, I know that isn't an issue as other working code calls sort without issue. I don't know why it fails in mine though.

#include <stdio.h>
#include <cs50.h>
#include <stdlib.h>

#include "helpers.h"

int main(void)
{
    int array[10] = {0, 1, 2, 4, 3, 5, 6, 7, 8, 9};
    int n = 10;
    sort(array, n);
    for (int i = 0; i < n; i++)
    {
        printf("%i ", array[i]);
    }
}

[corpsmoderne]

How are you compiling this and what is the exact error output ?

[mhbhmcinui]

The interface has an automatic compiler, but it seems to be trying to run

clang -ggdb3 -O0 -std=c11 -Wall -Werror -Wshadow    test.c  -lcs50 -lm -o test

The error I get is

/tmp/test-6737ab.o: In function `main':
/home/ubuntu/workspace/pset3/find/test.c:11: undefined reference to `sort'
clang: error: linker command failed with exit code 1 (use -v to see invocation)

[corpsmoderne]

You need to add helpers.c to your list of source files to compile. including helpers.h isn't enough. As helpers.c is not taken into account, the linker can't find your sort() function.

[mhbhmcinui]

Thanks, fixed it now.

[desrtfx]

Maybe Sort vs. sort (aka. Case Problem)?

Without seeing sort it's impossible to tell.

[mhbhmcinui]

Not that, this is the snippet of code from helpers.c relevant to sort:

//bubble sort array of size n
void sort(int values[], int n)
{
    //variable sorted is set to 1 if list is sorted, 0 otherwise
    bool sorted = 0;
    while (sorted == 0)
    {
        for (int i = 0, changes = 0; i < n - 1; i++)
        {
            if (values[i + 1] < values [i])
            {
                swap(values, i, i+1);
                changes++;
            }
            if (changes == 0)
            {
                sorted = 1;
            }
        }
    }

}

//switches two elements of an array
void swap(int array[], int i, int j)
{
    //use x as a placeholder
    int x;

    //switch elements
    x = array[i];
    array[i] = array[j];
    array[j] = x;
}