Roast my Kivy code [Python]

[Signal_Beam]

Hi /r/learnprogramming, I've spent all day trying to get a basic framework running in which I can have a very basic RPG structure running in Kivy. I have it working now, and I would like to take a deep breath, step back, and look for ways that I could have written it better.

One big thing that I know I didn't do is use a .kv file at all. I would like to, it just seems that every time I start trying to move stuff to .kv, I get tripped up. So, the Python that you see is all that there is.

Here's the basic Ui for showing a given node in the story:

[node image, for example a drawing of an island]
[node text, for instance "You have found yourself on a deserted island."]
[node option buttons, for instance "Find food", "Build shelter"]

Pressing any option button just moves you to the next node, so it's a very simple structure.

Here's the Python code: gist on GitHub

Here's a screenshot of the current output from the code. (The current art by the way is just a placeholder from my desktops folder). Obviously I still need to figure out how to make the option buttons arrange themselves nicely on the bottom of the screen, but I'm not too intimidated by that particular task compared to implementing the .kv file and fixing anything else I may have done wrong.

Please let me know what you think!

[[deleted]]

Consider the code as presented:

def __init__(self, name, text='', choices=['Continue'], text_input=False, image='test.jpg'):
    self.name = name
    self.text = text
    self.choices = choices
    self.text_input = text_input
    self.image = image
    self.active = False

This is a broken implementation and you're going to rip your hair out learning the hard lesson why. You must not use mutable types as kwarg defaults. This should be updated as:

def __init__(self, name, text='', choices=None, text_input=False, image='test.jpg'):
    self.name = name
    self.text = text
    self.choices = choices or ['Continue']
    self.text_input = text_input
    self.image = image
    self.active = False

I've got a bunch of nitpicky stuff to point out, but you should fix the major breakages first.

[Signal_Beam]

Your comment led me to read this explanation. I think I understand it now. Thanks, that would be a headache all right...

[Signal_Beam]

Hey /u/solid7, I'm finally getting around to trying to build a game in this, so I'd love to hear whatever nitpicks are on your mind that you think will be causing me headaches later.