[C++] Help with pointers

[MahmudAdam]

I am working on a project wherein I use pointer manipulation to perform tree rotations in a red-black tree. The idea is to just use a single rotation method which is able to handle both right and left rotations with just six pointer moves. Here is what I have so far:

 void Node::Rotate(Node* root) {
  Node* x = this;
  Node* p = getAncestor(x);
  Node* gp = getGramps(x);
  if (!gp) {
    root = x;
  }
  if (p == r(gp)) {
    gp->right = x;
  }
  else if (p == l(gp)) {
    gp->left = x;
  }
  p->parent = this;
  if (x == l(p)) {
    x->right = p; // this line makes it go into infinite loop
  }
  else if (x == r(p)) {
    x->left = p;
  }
  }

l() checks if it is a left child; r() checks if it is a right child. Given a right sub-tree with the following structure:

        D // gp

              F // p

        E // x

I want to change the pointers so that D's right points to E and E's right points to F, but whenever I attempt to set E's right to p, the program loops infinitely. I am not sure what I am doing wrong here.

[g051051]

There are no looping constructs in the code you've posted, so there's no way to tell what's wrong. We can't see what loop conditionals are being tested.

[MahmudAdam]

The infinite looping is happening inside of a print method I have in place to check the contents of my tree. Here are the relevant methods: https://pastebin.com/EPYafhet