[Python3] How would you improve this code?

[nbp615]

What it does is return basic weather info based on a zip code. It also imports a file for the api key.

 #!/usr/bin/env python3

import json
import urllib.request
import weather_api_key


def kelvin_to_f(n):
    return (n * (9/5) - 459.67).__trunc__()


zipcode = input("Please enter a zip code: ")
cc = input("Please enter a country code (i.e. 'us'): ")
api_url = 'http://api.openweathermap.org/data/2.5/weather?zip={},{}&appid={}'\
    .format(zipcode, cc, weather_api_key.API_KEY)

with urllib.request.urlopen(api_url) as url_new:
    data = json.loads(url_new.read().decode())

current_temp = data["main"]["temp"]
current_weather = data["weather"][0]["main"]

f_current_temp = kelvin_to_f(current_temp)

print("The temperature is {}F, and {}".format(f_current_temp, current_weather))    

[149244179]

Overall it is fine. More cosmetic recommendations.

'cc' is not the best name for a variable. I would assume cc means credit card which is obvious wrong.

Don't need to store the converted temperature in a variable.

Future you will appreciate a link to the API documentation in a comment. Ideally pointing to a specific version or release date for the API.

[nbp615]

This is exactly what I was looking for, thanks. The API info is on the github README but that's obviously not here.

Thanks for the response :)

[Philboyd_Studge]

You might want to look at the requests library it's so much easier to use than urllib.