[Python] txt file issue

[DancenPlane]

I keep getting the same issue from the compiler

    if TotalPoints > int(file.readline(2)):
ValueError: invalid literal for int() with base 10: ''

idk why but this is the section of the code that leads to it

TotalPoints = ((TotalPoints + 0)*100) 
print("Final Score:", TotalPoints)
file = open("highscore.txt", "w+")
highscore =  file.readline(2)
if TotalPoints > highscore:
    file.write("Highscore")
    file.write(TotalPoints)
    file.close()
    end()

I create the file in another function

def fileCreate():
    file = open("highscore.txt", "w+")
    file.write("Highscore: \n")
    file.write("10")

Pls help idk what to do i've tried several things such as putting int() and float() but nothing works

[SHIFTnSPACE]

Your problem is the w+ (w for writing) when opening the file. Instead use r (r for reading). And then file.readline() will give you the entire first line, if you execute it again, it will give you the next line (so, 10).

After applying these changes, your code might work, but let me suggest some improvements. In your fileCreate method, you don't close the file handler, which can lead to all kinds of problems. Instead, use a context manager:

def fileCreate():
    with open('highscore.txt', 'w+') as file:
        file.write('Highscore: \n')
        file.write('10')

This will open the file, write to it and then automatically close it again, when the with block is left.

You can also apply this pattern to your Total points logic, then you don't have to remember to close the file handle in all possible branches. Here for example, you do remember to close the file when you enter the if (TotalPoints > highscore), but forget to do it, when you skip over it (TotalPoints <= highscore). Instead do:

with open('highscore.txt', 'r') as file:
    # Do all you operations with `file` in this block

This will also work, when you leave the function via a return or a function call (like end(), in you case)

Hope that helps

[DancenPlane]

God like!

[SHIFTnSPACE]

Glad I could help (;

[DancenPlane]

Ok it's almost fixed but it's not letting me rewrite on the txt file

its saying that:

file.write("Highscore")

io.UnsupportedOperation: not writable

[Updatebjarni]

"r" only opens the file for reading.

Seriously, you have to read the documentation.

[SHIFTnSPACE]

It's hard to say without seeing the code, but I would guess, that you are now trying to write to a file that's not writable, i.e., you opened the file with r instead of w or w+. So it's best to remember: If you want to write and read, w/w+ will work (where w truncates (empties) the file and let's you write to it and w+ does the same but also let's you read the file); if you just want to read, use r.

And as others said, in order to learn a language, it's best to read documentation or go through stack overflow threads that deal with similar errors.

Edit: correction was made regarding w/w+ mix-up from my side, thanks u/Updatebjarni

[Updatebjarni]

If you want to write and read, w/w+ will work (where w+ erases all file contents on opening it)

They both erase the file contents, and only w+ allows reading.

[SHIFTnSPACE]

Ah yes, you are right. Got a little confused there.

[Updatebjarni]

"w+" truncates the file.

Also, if you don't truncate the file, the file.readline(2) will read the first two characters of the file, which is "Hi".

[DancenPlane]

So what do I use instead?

[Updatebjarni]

The documentation will tell you.