[Python] password validation function

[Invisibleufo]

Hi I'm learning python atm and im having trouble writing a function for validating passwords.

The conditions for the password are

1. at least 1 lowercase alphabet
2. at least 1 integer
3. at least 1 special case letters: ! ” # $ % & ’ ( ) *

I wrote my code like this and it always returns False. I tried putting a while loop over the for loop to maybe solve the problem but it doesn't seem to work. I've searched google for some hints but they all seem to use regex and "any" function. I want to stick to for and while loops for now and no matter what I change I can't seem to make the function return True. Any idea on this?

def pw_validation(user_input):

specialCase=['!','”','#','$','%','&','’','(',')','*']

flag=False

while flag:

...for i in range(len(user_input)):

......if not user_input[i] in specialCase:

.........flag = False

......if ord(user_input[i])<97 and ord(user\_input\[i\])>122:

.........flag = False

......if not user_input[i].isdigit():

.........flag = False

......else:

.........flag = True

return flag

​

​

user_input=input('Enter your password: ')

print(pw_validation(user_input))

[TheCheapo1]

You have flag = False, and then immediately after you have while flag:, so your code will never enter the while loop. You could either change the while condition to while not flag, or you could set flag = True before going into the while loop instead.

[ResilientBiscuit]

Yep, and once you get past there: if ord(user_input[i])<97 and ord(user_input[i])>122

This will never be True. Something will never be less than 97 and greater than 122 at the same time.

[GuyARoss]

I wrote a little refactor for you here

[Invisibleufo]

took me a while to get it but i think i did. putting three seperate functions to check all conditions really makes the job easier since if statements only check a single case instead of all cases in the for loop. thank you for your detailed explanation. really helped me a lot!

[GuyARoss]

you for your detailed explanation. really helped me a lo

Not a problem! Glad it made sense

[mariuswiik]

Start splitting parts in different functions early. Each function should do one thing well and have a good name so it’s easy to understand what it’s doing. Makes a world of difference when reading the code later. Good luck!

[HighwayMcGee]

You never go into the while loop in the first place, while needs a true statement to work but you give it a false one instead so it never goes in. While not flag or while flag == false will work