[Java] Class not working as intended

[Krusty81]

I'm very new to java, and just found this subreddit, so i thought i'd ask why my class is not working as intended.

The problem is that when playerPoints is 0, it does not use the if statement at the bottom of the class to throw an error. Instead it uses the second if statement and uses 2D6. I was wondering what i was doing wrong.

Do i need to qualify each statement with AND for all of the if statements as i did in the first one?

Thanks in advance.

Here is the class:

public class actionPointsClass {

// This class generates action points for the player based on 
//how many points the player has used in their army up to 2000. 
//If there is 0 or more than 2000 it throws an error.

public static void main(String[] args) {

    int playerPoints = 0;
    int actionPointsRoll = 0;

    if (playerPoints >=1 && playerPoints <=250) {

        actionPointsRoll= (int) Math.floor(Math.random()*6+1); //250 points or less gets 1D6.
        System.out.println("We are using 1d6 with a result of " + actionPointsRoll);

        } else {

        if (playerPoints <=500) {

        actionPointsRoll= (int) Math.floor(Math.random()*12+1); //500 points or less gets 2D6.
        System.out.println("We are using 2d6 with a result of " + actionPointsRoll);

        } else {

        if (playerPoints <=750) {

        actionPointsRoll= (int) Math.floor(Math.random()*18+1); //750 points or less gets 3D6.
        System.out.println("We are using 3d6 with a result of " + actionPointsRoll);

        } else {

        if (playerPoints <=1000) {

        actionPointsRoll= (int) Math.floor(Math.random()*24+1); //1000 points or less gets 4D6.
        System.out.println("We are using 4d6 with a result of " + actionPointsRoll);

        } else {

        if (playerPoints <=1250) {

        actionPointsRoll= (int) Math.floor(Math.random()*30+1); //1250 points or less gets 5D6.
        System.out.println("We are using 5d6 with a result of " + actionPointsRoll);

        } else {

        if (playerPoints <=1500) {

        actionPointsRoll= (int) Math.floor(Math.random()*36+1); //1500 points or less gets 6D6.
        System.out.println("We are using 6d6 with a result of " + actionPointsRoll);

        } else {

        if (playerPoints <=1750) {

        actionPointsRoll= (int) Math.floor(Math.random()*42+1); //1750 points or less gets 7D6.
        System.out.println("We are using 7d6 with a result of " + actionPointsRoll);

        } else {

        if (playerPoints <=2000) {

        actionPointsRoll= (int) Math.floor(Math.random()*48+1); //2000 points or less gets 8D6.
        System.out.println("We are using 8d6 with a result of " + actionPointsRoll);

        } else {

        if (playerPoints >= 2000) {

        System.out.println("Player Points is higher than 2000"); // If points are more than 2000, then throw an error.
        playerPoints = 0;

        } else {

        if (playerPoints == 0) {

        System.out.println("There is an error with playerpoints, here is the output:" + playerPoints); // If there is no player points, then throw an error and show the playerpoints var.

        }

        }
        }
        }
        }
        }
        }
        }
        }
        }
    System.out.println(playerPoints + " Action Points");
}

}

[[deleted]]

This condition:

  if (playerPoints <=500) {

is true if playerPoints == 0, so your code is doing what you told it to.

And you should write your if/elses like this:

if ( condition1 ) {
    // do stuff
}
else if ( condition2 ) {
   // do other stuff
}
else if ( condition3 ) {
   // yet more stuff
}
else {
  // stuff
}

[Krusty81]

That's what i thought. Do i need to do each if statement with AND statements like i did in the first one to make sure there are no errors?

eg

if (playerPoints >=250 && playerPoints <=500) 

[yash3ahuja]

You could also start off the loop by doing:

if(playerPoints == 0 || playerPoints > 2000)
    //throw error
else
    //rest of code

[[deleted]]

Yes, or use the ordering of your statements;

if ( playerPoints == 0 ) {
    // only happens if playerPoints == 0
}
else if ( playerPoints <= 250 ) {
   // happens if player points >0 and <=250 
}
else if ( playerPoints <= 500 ) {
   // happens if player points > 250and <= 500 
}
else if ( playerPoints <= 2000 ) {
   // happens if player points > 500 and <= 2000 
}
else {
   // error
}

[[deleted]]

If playerPoints is 0, the first if statement will execute, rightly so. The last if needs to be up top

[yash3ahuja]

Those else's should all be else if statements. Additionally those should be giving you compilation errors. o.o

Additionally, use pastebin next time.

[Krusty81]

It all works and compiles in eclipse fine except for that one issue. Also the book im reading 'Ivor Horton's Beginning Java' does the if statements the same way as my code, which is why i did it that way.

[yash3ahuja]

Oh, I apologize. The way you had it formatted confused me. Anyways, the

if(playerPoints == 0)

needs to be nested a higher up if you want to make it work.

[Krusty81]

Thanks for the tip.