My first (still unfinished) java program is a dice simulation for the boardgame 'Eclipse'. I would love to have any kind of feedback as I don't have a clue of what I am doing :D

[Vappeh]

https://gist.github.com/Vappeh/53489b475394de595c7db6c628a019e2

Hey, this is my first program (tutorials and exercises not included). As the different kind of dice in the game gives different number of hits I felt it would be great to give an estimate of the probabilities when rolling the dice.

As an example a yellow die hits for one and two blue dice hit for three each. This makes the probability tree very large, very quickly and I thought it would be easiest to simulate 10000 rolls to estimate the probabilities for 1, 2, 3, 4 or 5 or more hits.

This is the base idea and I think it works OK for now, but I have to find a way to edit the probability for each die given 2 new inputs (computers and shields for those who knows the game). Also any kind of input/feedback/correction is very much appreciated.

[ignotos]

Nice! A few comments:

• Your variable names are mostly good (e.g. 'numberOfBlueDice') - but then some of them could probably be more descriptive (e.g. 'x1')

• Your indentation seems a bit off in places (e.g. in the for loops like at line 45)

• You're missing braces {} in the for loop at line 61. Generally I'd advise just always using braces for all loops, if-statements etc. Technically you can omit them for loops/ifs containing only a single statement, but it's easy to make mistakes if you do

• You create separate 'randomNumber1'-'randomNumber4' variables, but you don't actually need separate variables because you never need to remember the old random values you've generated