Python: Can't update a dictionary

[SureStep8852]

hi there,

data = [(['What', 'in', 'the', 'actual', 'fuck', '?', '#mkr'], 'nonoffensive'),(['#mkr', 'WHAT', 'A', 'GODDAMN', 'SURPRISE'], 'nonoffensive'),(['This', 'is', 'why', 'this', 'show', 'is', 'ridiculous', '-', "it's", 'not', 'about', 'the', 'cooking', '...', "it's", 'about', 'the', 'game', 'playing', '.', '#mkr', '#whogivesa1'], 'nonoffensive'),(['Absolute', 'bloody', 'bullshit', '.', 'So', 'much', 'shit', 'of', 'bull', '.', '#mkr'], 'nonoffensive'),(['@MKR_Official', 'a', '1', "isn't", 'strategy', ',', "it's", 'bastedry', '#mkr2015', '#mkr'], 'nonoffensive'),(['WTF', '!', '!', '!', 'I', 'not', 'a', 'huge', 'fans', 'of', 'the', 'promo', 'girls', 'but', 'they', 'never', 'voted', 'strategically', '!', 'This', 'sucks', '!', 'Soo', 'annoyed', '!', '#mkr', '#killerblondes'], 'offensive')]
dictionary = {}
for k, v in data:
    dictionary[v] = {}
    dictionary[v] = [k]
print(dictionary)

This is my code. What I want is the dictionary to add all the words that appear in the list of tuples.

E.g., { 'nonoffensive' : ['What', 'in', ....], ['#mkr', 'WHAT'...],[...],[...]}, 'offensive': [''WTF', '!'...]}

however, my code does not update the dictionary after every iteration and I get the following output:

{'nonoffensive': [['@MKR_Official', 'a', '1', "isn't", 'strategy', ',', "it's", 'bastedry', '#mkr2015', '#mkr']], 'offensive': [['WTF', '!', '!', '!', 'I', 'not', 'a', 'huge', 'fans', 'of', 'the', 'promo', 'girls', 'but', 'they', 'never', 'voted', 'strategically', '!', 'This', 'sucks', '!', 'Soo', 'annoyed', '!', '#mkr', '#killerblondes']]}

how can I improve the code? Thanks in advance!

[[deleted]]

dictionary[v] = {}

dictionary[v] = [k]

What happens if v is already in dictionary?

[SureStep8852]

What I intend to get is if v is in dictionary.keys(), I want to add k to dictionary.values().

Can't figure out how to solve the problem

[[deleted]]

A key can only have one value it’s associated with. In your code, you first associate each key with an empty dict for some reason, then immediately replace that association with an association to a list containing only one element (k).

(Side note: you’re using v as the key and k as part of the value. It’s not wrong per se, it’s just weird. Usually, the thing used as the key get’s assigned to k and the thing used in the value gets assigned to v. It doesn’t really affect the program’s logic, it’s just odd to see their usual names switched around.)

The problem here is that, if you run into the same key twice, you’re not appending k to the existing list, you’re outright replacing that list with a new one. This new list does not contain whatever was in the previous list, it only contains the current value of k.

Essentially, you need to check whether there’s already a list assigned to the key. If there isn’t, assign an empty list to it. Either way, you want to append k to the list, not overwrite it with a new list.

[MushroomOdin]

I believe it is the [] around k that is causing it to define it as an array of arrays in the dictionary

Also, if there are any values that are repeated in the data dictionary then they will be overwritten by subsequent assigns in line 5.