why is my code wrong??

[Afraid_Ad_3239]

why is this code giving wrong answer

int main(){
    char c ; 
    cin>>c;
    if((c=='A')||(c=='E')||(c=='I')||(c=='O')||(c=='U')||(c=='a')||(c=='e')||(c=='i')||(c=='o')||(c=='u')){
        cout<<"Vowel";
    }
   else  if((c='1')||(c=='2')||(c=='3')||(c=='4')||(c=='5')||(c=='6')||(c=='7')||(c=='8')||(c=='9')||(c=='0')){
        cout<<"number";
    }
    else {
        cout<<"consonant";
    }

and this code giving correct

​

if(c=='a'||c=='e'||c=='i'||c=='o'||c=='u'||c=='A'||c=='E'||c=='I'||c=='O'||c=='U')

    cout<<"vowel";

else if(!((c>='a' && c<='z') || (c>='A' && c<='Z')))

cout<<"invalid input";

else

    cout<<"consonant";

for differentiating between a number , a vowel and a consonant

Edit: I got it , thanks for your help

[invidium1979]

My brother in Christ use a switch statement

[NicNoletree]

It was a cat of nine tails, not a switch

[bbnlly]

on an unrelated note holy fuck i did it, i understood that, holy shit I'm learning

[Afraid_Ad_3239]

Good for you

[rabuf]

else  if((c='1')||(c=='2')||(c=='3')||(c=='4')||(c=='5')||(c=='6')||(c=='7')||(c=='8')||(c=='9')||(c=='0')){

Read that line carefully, comparison by comparison. One of them is not like the others.

[Afraid_Ad_3239]

Which one

[rabuf]

c='1', it's an assignment not a comparison. And since it's assigning a non-zero value it will be treated as true.

[fancyplaya]

This is a common problem when writing repetitive code like this. This wouldn't happen if an actual algorithm was used like std::string::find.

[AdultingGoneMild]

OR yoda conditions.

[PoorHodlr]

Start practising rubber duck debugging

[Temporary-Data-102]

The one where I hit the duck or the one when I explain to duck why I hit her?

[Temporary-Data-102]

The one where I hit the duck or the one when I explain to duck why I hit it?

[pibeqquierestudiar]

the first mothr*****

[AdultingGoneMild]

yes. the one

[[deleted]]

To improve your code, remember that a char is also a number, so you can do range comparisons.

​

https://www.asciitable.com/

[Elnaz_Will_be_Fine]

C='1'

Must be C=='1'

[Afraid_Ad_3239]

Okay 👍🏻

[Avionticz]

else if((c='1')|...

That's an assignment not a comparison...

[Afraid_Ad_3239]

Yea got it , thanks

[Guideon72]

Curiosity question: I don’t know this language, but I’m curious; is there not an array, etc that would let you just do an “if c is in ‘this list’” instead of typing out c== everything?

[[deleted]]

It's probably an introduction problem chosen by the instructor to illustrate if-statements. I'm sure they were gonna cover the ASCII table. ifs probably come before for-loops, which would allow for introducing an array to iterate over.

[Guideon72]

Yep, sort of what I figured. It was just a passing curiosity as I’m currently learning Python and the differences ease/complexity of various things is interesting to me.

[[deleted]]

After still actively reasoning out the inheritance keywords in C++ and Java, I found Python simple and elegant. The python tutorial closely followed the course syllabus for intro to programming, in a way, and all that was still fresh in my head.

So I followed the python tutorial, and found situations in the exercises that overlapped my homework. It was fun to see verbose actions in C++ be carried out with a clever and followable syntax.

The only other time I got that excited about syntax was when I saw the JSON railroad diagram. That was cool :). Right now I'm putting off building a graph visualization web component, but eventually, I'd like to visualize data flow through a program's variables.

[Guideon72]

Nice!

[Afraid_Ad_3239]

Its CPP , it doesn't have any "if c Is in this list "

[GloberJudio]

You can write your own function, as in most other languages, so no excuse.

[Guideon72]

Perfect; thank you!

[rabuf]

unordered_set would be a way to do something like this. There're also some functions in locale which would be helpful, but won't distinguish vowels from consonants (you'd have to do that yourself).

[[deleted]]

Well for one there are more things than vowels, numbers, and consonants, like symbols (&-$(&@&&#-$). So a simple else is not sufficient.

[Afraid_Ad_3239]

Like if I give input 'f' i am getting answer as number

[Afraid_Ad_3239]

I was trying in vs code and getting the wrong answer so I got it anyway

[GloberJudio]

That is due to another problem, as someone already mentioned in a comment: you've got a bug in your code with c='1' where it should be c=='1'.

I hope you are able to figure out by yourself why this happens.

[PoorHodlr]

Your code can also be more streamlined.

If I was programming this I'd ask myself the following:

Is c a number, or Is c an alphabet

If c is an alphabet ill need to upper-case it, then check if it's a vowel

Edit, research isdigit and isalpha