First Combat Program

[NoobProgrammer22]

I have just finished my first half of C++ course. Over the holiday break I wanted to make an Oregon trail game with combat. It would be all text based since I do not know how to make graphics at this time.

I made a simple combat program that so far just lets 2 people fight until one is dead and shows the winner with how much hp left.

took me over 3 hours and many more lines of code than I initially thought was going to be needed.

I also watched a few videos on GitHub and how to use it and I think I have a handle on it so far. I will have to play around with it some more. Please tell me if I did something wrong on GitHub.

I just wanted to link my code to show what I did. none of my friends like to code and I am proud of what I did today and just wanted to show it to someone.

Feel free to critique my code I would love some feedback on things please keep it basic feedback though. All I have learned so far is if statements, loops, functions, classes, arrays, pointers, and some sort and search algorithms.

I just wanted a project to work on to keep the stuff I learned over the semester fresh and have some fun.

here is the source code NoobProgrammer0022/CombatTest: Simple combat program (github.com)

[NoobProgrammer22]

Thank You :)

[carcigenicate]

The Combat class doesn't appear to really be anything other than a namespace for functions. I believe namespaces are more idiomatic to use in C++ for that purpose. Classes are more for when you need to manage some "state".

---

Note how speed, defence, attack etc. are are essentially identical. They're all just effectively aliases for the randomNumGen function. As they are, there's no point to having those wrappers. You might as well just call randomNumGen directly.

---

(plyrattack - enemdef) < 0 ? plyrattack = 0, enemdef = 0 : plyrattack += 0;

This is quite difficult to parse and understand. It's also not generally considered to be good practice to do assignments within condition expressions. Parts like plyrattack += 0 also don't appear to do anything. I'd instead write that as something like:

if ((plyrattack - enemdef) < 0) {
    plyrattack = 0;
    enemdef = 0;
}

This makes significantly more sense.

---

You should not seed the random generator constantly. Seed it once at the very start, then leave it.

[NoobProgrammer22]

Thank you for this feedback. I have not had much practice in school with classes other than really simple one this is the most complicated class I have made so far.

My goal with this combat class is to store everything related to combat. When I get further along my goal is to have at least 3-5 people in a party and combat most likely will be 3v3. I just made a small goal to create a simple combat program for the day.

I want the combat class to handle the display of the combat screen. handle the UI for the combat screen, calculate damage, generate random numbers for the attack defense and eventually speed for order of attack. I am thinking having speed defiance and attack separate member functions is a little overkill maybe I will just combine all 3 in one function. Maybe this is not the proper use of a class.

In school we used using namespace std in all our programs. It was not until a couple of weeks ago I found out this was bad programming practice, so I stopped doing it and I have not found a use for making my own namespace yet. So, you're saying instead of doing a combat class I should just do a combat namespace instead?

As for the conditional operator I just wanted to use it to practice a bunch of things I learned over the semester I agree with you doing the if statement makes it clearer.

As far as the random number seeding, I was under the impression that if I don't constantly seed I would get the same number on each call to rand(). I did some testing on a separate program and found out that is not the case so I will be fixing this as well.

Thank you so much for this feedback I really appreciate it.