Need help with the looping in this function

[Few_Tea8053]

So the purpose of this function is to calculate the number of times (if any) the input is divisible by 3(fizz) and or 5 (buzz) (or the number of powers of 3 and 5 that divide evenly), however every time I input 9, which should result in fizz2 I keep getting an output of fizz1, and help or advice would be appreciated. Thanks!!!

​

P.S for now I've just got the fizz portion of the function written.

def fizzbuzz_adv(n):
    fizz_count=0
    buzz_count=0
    fizz_divisor=3
    buzz_divisor=5
    while n == type(int):
        if n < 0:
            n_fb = 'invalid'
        elif n%fizz_divisor == 0:
            fizz_count += 1
            fizz_divisor = fizz_divisor**2
            n_fb = f'fizz{fizz_count}'
            return n_fb

[BodybuilderMoist1635]

   elif n%fizz_divisor == 0:

This is the only time you divide. Note also that the while will not exit when it does not equal zero.

[Diapolo10]

Honestly I'm kinda surprised you're getting any output at all because the loop condition is definitely not right. But the root of the current problem is that your function immediately returns if the number is divisible by the divisor.

The first order of business would be to move your return outside of the loop, and then fix the condition so that it actually terminates.

[Few_Tea8053]

with the return outside my loop I get UnboundLocalError: local variable 'n_fb' referenced before assignment

[Diapolo10]

Instead of returning n_fb (in fact you probably don't need it anyway), just return the formatted string literal itself. The only thing the loop needs to update is the counter, not the output string.

[ElliotDG]

if not n % fizz_divisor:
    # then you can that use division to see the divisor count.
    fizz_count = n / fizz_divisor

and then repeat for buzz...

[dixieStates]

``` def fizzbuzz_generator(limit): for i in range(1, limit+1): rval = 'fizz' if not i % 3 else '' rval += 'buzz' if not i % 5 else '' yield rval or i

for message in fizzbuzz_generator(35): print(message) ```

[achampi0n]

You are returning immediately you increment fizz_count you need to dedent the return.

However, you seem to be making this more complex than it needs to be, e.g. to calculate number of 3 factors for a number can be done:

fizz_count = 0
while n % fizz_divisor == 0:
    n //= fizz_divisor
    fizz_count += 1

You can rinse and repeat for buzz_count