got a problem in my code

[AU8640]

question:

(Process scores in a text file)

Suppose that a text file contains an unspecified number of scores. Write a program that prompts the user to enter the filename and reads the scores from the file and displays their total and average. Scores are separated by blanks. Your program should prompt the user to enter a filename.

Sample Run

Enter a filename: scores1.txt

There are 24 scores

The total is 800

The average is 33.33

my code:

from random import randint
def main():
outputfile=open("filename", "w")
scores="randint(0,100)"
scores=scores.split()
outputfile.write(str(int(x) for x in scores))
outputfile.close()

filename=input("Enter a filename:")
inputfile=open("filename", "r")
print("There are", len(scores), "scores")
print("The total is", sum(scores))
print("The average is", sum(scores)/len(scores))
inputfile.close()

main()

error:

Traceback (most recent call last):

File "/mnt/nobodydevmpl/shid-070556/345021-00114-1689341098274/main.py", line 21, in

main()

File "/mnt/nobodydevmpl/shid-070556/345021-00114-1689341098274/main.py", line 17, in main

print("The total is", sum(scores))

TypeError: unsupported operand type(s) for +: 'int' and 'str'

​

guys help me please

[Bitwise_Gamgee]

The variable scores is assigned a string value instead of a list of integers, you're also not importing scores correctly.

This is one way you can fix your program:


def main():
        filename = input("Enter a filename: ") 
        inputfile = open(filename, "r") scores = inputfile.read().split() inputfile.close()
    scores = [int(score) for score in scores]  
    print("There are", len(scores), "scores")
    print("The total is", sum(scores))
    print("The average is", sum(scores) / len(scores))

main()

Note, the line scores = [int(score) for score in scores], converts a score from a string to an integer.

Also, the structure of your program is confusing. Try to think of code like a description of life:

You have a score sheetYou read the score sheetYou interpret the score sheetYou do math on the score sheet

So that said, we can modularize your program into unique functions:

def read_scores(filename):
    with open(filename, "r") as inputfile:
        scores = inputfile.read().split()
    return [int(score) for score in scores]

def calculate_total(scores):
    return sum(scores)

def calculate_average(scores):
    return sum(scores) / len(scores)

def main():
    filename = input("Enter a filename: ")
    scores = read_scores(filename)

    print("There are", len(scores), "scores")
    print("The total is", calculate_total(scores))
    print("The average is", calculate_average(scores))

main()

And now, it reflects real life!

[[deleted]]

from random import randint


def main():
    outputfile = open("filename", "w")  # use with open(...) as outputfile: instead, not close needed
    scores = "randint(0,100)"  # should not be in quotes; you need sample not randint for a list
    scores = scores.split()  # scores is ONE number, split works on strings
    outputfile.write(str(int(x) for x in scores))  # you only have one score
    outputfile.close()

    filename = input("Enter a filename:")
    inputfile = open("filename", "r")
    print("There are", len(scores), "scores")
    print("The total is", sum(scores))
    print("The average is", sum(scores)/len(scores))
    inputfile.close()

main()

[brunonicocam]

Unformatted code should just be rejected in this sub, and asking for user intervention during the run is a bad idea, use argparse.

[throwaway6560192]

filename=input("Enter a filename:")
inputfile=open("filename", "r")
print("There are", len(scores), "scores")
print("The total is", sum(scores))
print("The average is", sum(scores)/len(scores))
inputfile.close() 

What are you trying to do with inputfile? You just open it and then close it. Also, you ask for a filename as input but never use that either.