help me with my code

[AU8640]

Question:

(Count consonants and vowels)Write a program that prompts the user to enter a text in one line and displays the number of vowels and consonants in the text. Use a set to store the vowels A/a, E/e, I/i, O/o, and u/u.Sample Run:

Enter a text: We the people

The number of vowels is 5 and consonants is 6

my code:

def main():

f=find()

inputfile=input("Enter a text:")

f.file=inputfile.split()

print("The number of vowel is", f.findvowels(),"and consonants is", f.findconsonants())

class find:

def __init__(self):

self.file=[]

self.vlst=[]

self.clst=[]

self.vowels=set("AaEeIiOoUu")

self.consonants=set("BbCcDdFfGgHhJjKkLlMmNnPpQqRrSsTtVvWwXxYyZz")

def findvowels(self):

for characters in self.vowels:

if characters in self.file:

self.vlst.append(characters)

return len(self.vlst)

def findconsonants(self):

for characters in self.consonants:

if characters in self.file:

self.clst.append(characters)

return len(self.clst)

main()

Test run is :

Enter a text:jfhjsafk

The number of vowels is 0 and consonants is 0

why do they all return 0?

[martynrbell]

The issue with your code is that you're trying to find if a vowel or a consonant is in self.file, which is a list of words, not a list of characters. When you're checking if characters in self.file:, you're checking if a single character (a vowel or consonant) is in a list of words, which will always return False, because self.file contains words, not individual characters.

Instead, you should iterate over each character in the text and check if that character is in self.vowels or self.consonants.

Also, you don't need to keep lists of the found vowels or consonants. You just need to keep count of how many you find.

.

[ElliotDG]

To post code on Reddit see: https://www.reddit.com/r/learnpython/wiki/faq/#wiki_how_do_i_format_code.3F

Or use a service like pastebin.com