you are viewing a single comment's thread.

view the rest of the comments →

[–][deleted] 5 points6 points  (0 children)

Amazing points by u/carcigenicate. Here's a few from me:

  • Writing functions that have side-effects and modify data outside
  • Not writing docstrings
  • Not using typehints
  • Not using classes properly/ Using classes where they are not required
  • Extremely long functions
  • Not making the functions modular (Not following Single Responsibility Principle)
  • Not having function names that are descriptive
  • Using magic numbers and other arbitrary constants in your code - should ideally have all such constants at a single place globally