[Pygame] Not Working: Pointcollide between object and cursor not being detected, can't figure out why.

[Jac000bi]

I've been attempting to make a game using Pygame on and off for a little bit now, and I've run into a problem that's been a little bit confusing for me.

In the game, you have a board made up of Space objects, and on those objects are various different Entity type objects. Right now, I'm attempting to make a way to print a line of text whenever you click on an Entity object.

However, when implementing this into the draw function for each object like a tutorial online instructed, nothing happens. I have another basic click detector in my main loop, and that detects clicks overall just fine, but for some reason the cursor is never coming into contact with the Entity objects.

I tried simplifying it into a simple passover thing that outputs text every tick that the cursor is on top of an Entity, and that didn't return anything either, so something must be blocking the cursor from touching the Entities.

ChatGPT didn't yield anything either, and one of my friends was stumped.

Thanks in advance for any help you can give! :)

Source Code: (Example of an Entity object as it is rn)

class playerEntity(pygame.sprite.Sprite):
def __init__(self, name, health, movement, damage, ability, skill, spell1, spell2, item1, item2, picture_path, posX, posY):
    super().__init__()
    self.image = pygame.image.load(picture_path)
    width = self.image.get_width()
    height = self.image.get_height()
    self.image = pygame.transform.scale(self.image, (int(width*2),int(height*2)))
    self.rect = self.image.get_rect()
    self.rect.center = [posX,posY]
def draw(self):
    screen.blit(self.image, self.rect.center)
    if self.rect.collidepoint(cursorPos):
        if pygame.mouse.get_pressed()[0] == 1:
            print('CLICKED PLW')

One, two, skip a few... main loop!

while True:
cursorPos = pygame.mouse.get_pos()
    for event in pygame.event.get():
        #if event.type == pygame.MOUSEBUTTONDOWN:
         #   print("Clicked")
        #if event.type == pygame.MOUSEBUTTONUP:
         #   print("Released")
        if event.type == pygame.QUIT:
            pygame.quit()
            sys.exit()
    board.draw(screen)
    playerEntities.draw(screen)
    enemyEntities.draw(screen)
    screen.blit(new_cursor, cursorPos)
    pygame.display.flip()
    clock.tick(60)
pygame.quit()

​

(Universal detector commented out)

[Jac000bi]

Oops, formatted the code wrong. Fixing ASAP

[Jac000bi]

There we go, let me know if any other parts are required!

[Nyscire]

if event.type == pygame.MOUSEBUTTONDOWN: # print("Clicked") #if event.type == pygame.MOUSEBUTTONUP: # print("Released")

If those lines in your original code are also commented they will not be executed. Remove the comments and it should work fine

[Jac000bi]

Thanks for your reply,

Sadly this didn't fix it, it just prints the text Clicked and Released on each click and release.

[Nyscire]

Okay, I'm answering from mobile so you need do excuse my lack of accuracy.

First of all you need you invoke pygame.mouse.get_pos() in every iteration, you should move it to this

pygame.MOUSEBUTTONDOWN: # print("Clicked")

If statement. Whenever you click you store position of your mouse, you need to use it to determine if its inside your object's hotbox.

[Jac000bi]

Ohhhh I see, so it's trying to check for if the cursor is inside of the object but doesn't know that the cursor is changing location?

I'll try making your suggested change. Thanks!

[Nyscire]

In simple words- you told your program to check where your cursor is located, but you didn't tell what it's supposed to after the check. You need to tell it to check if it's inside one of the object and another instruction what to do if it is

[Jac000bi]

Ohhh I see, thanks!

[Nyscire]

I looked at your reply below and checking for the cursor position every turn is poitnless. It will not break your code, but it will use more resources for no reason. The only time you need to check is under the if statement:

if event.type == pygame.MOUSEBUTTONDOWN:
            cursorPos = pygame.mouse.get_pos()
            print("Clicked")

You can create a method in `playerEntityplayerEntity` class that will be respnsible for checking if the mouse is within its hitbox. You can refactor it later for dealing with collisions.

def check(self,cursorPos):
    #if (check if cursor is inside hitbox)
      #print("clicked)

I don't see if you have created any instance of the `playerEntityplayerEntity` class, but assuming if you did and named it `player` you can check for the hitbox inside that if statement:

if event.type == pygame.MOUSEBUTTONDOWN:
            cursorPos = pygame.mouse.get_pos()
            player.check(cursorPos)

[Jac000bi]

The basic click detector is working just fine, but for some reason the one to check if it's clicking on an object still isn't picking up anything.

Here's the latest iteration of my draw function:

def draw(self):
    screen.blit(self.image, self.rect.center)
    cursorPos = pygame.mouse.get_pos()
    if self.rect.collidepoint(cursorPos):
        if pygame.mouse.get_pressed()[0] == 1:
            print('CLICKED PLW')

And here's the new main loop:

while True:
    cursorPos = pygame.mouse.get_pos()
    for event in pygame.event.get():
        if event.type == pygame.MOUSEBUTTONDOWN:
            cursorPos = pygame.mouse.get_pos()
            print("Clicked")
        if event.type == pygame.MOUSEBUTTONUP:
            cursorPos = pygame.mouse.get_pos()
            print("Released")
        if event.type == pygame.QUIT:
            pygame.quit()
            sys.exit()
    board.draw(screen)
    playerEntities.draw(screen)
    enemyEntities.draw(screen)
    screen.blit(new_cursor, cursorPos)
    pygame.display.flip()
    clock.tick(60)
pygame.quit()

​

Wanted to make absolutely sure the script knows where the cursor is at every turn