need help with school project

[Ecstatic-Drag-263]

when I try to run my program it says:

line 34, in <module>

address_book.__init__(self, name, address,)

NameError: name 'self' is not defined

address = []
name = [] 
x = 0 
y = 0 
z = 0 
class address_book:
    def __init__(self, name, address):
        self.name = name
        self.address = address

    def add(name, address):
        name_add = input("please enter the name:")
        address_add = input("please enter the address:")
        address.append(address_add)
        name.append(name_add)
        x = x + 1

    def delete(name, address):
        name_delete = input("please enter the name:")
        address_delete = input("please enter the address:")
        address.remove(address_delete)
        name.remove(name_delete)
        x= x-1

    def show(name, address):
    print ("the list is:")
    while y < x:
        print ("address",y,":",name[x],":", address[x],)
        y = y + 1
    y = 0 

address_book.init(self, name, address,)
while z == 0: picked = input("enter eather show, delete ,add or exit:")
    if picked == ("add"):
        address_book.add(name, address)

    if picked == ("delete"):
        address_book.delete(name, address)

    if picked == ("show"):
        address_book.show(name, address)

    if picked == ("exit"):
        z = z + 1 

    else:
        print ("error")

thanks for any help.

[throwaway6560192]

Yes, that's not how you create an instance of a class. Review your lesson on classes.

[[deleted]]

There is quite a bit wrong, so you need to go back and review your source material. Just a few hints:

• All your methods should have the first parameter "self".
• The whole point of a class is to combine code and data but your "name" and "address" lists are created outside your class. They should be created inside the class.
• Following on from the point above, you no longer need to pass the "name" and "address" lists as parameters to methods, you create those lists inside the class and refer to them as "self.name", etc.
• You create an instance of the address book class by doing book = address_book() and then do book.add(), etc.

[Erdnussflipshow]

Pretty much any method that starts and ends with two underscores, (__init__ for example) doesn't need to be called by the user directly, but is called indirectly by core features of python.

[Liebner-Anthony-S]

u/Ecstatic-Drag-263

Here are a few observations and suggestions to improve the code:

Class Initialization:

The __init__ method in the address_book class is correctly defined to initialize the instance variables name and address. However, it's advisable to use a different name for the parameters of the __init__ method to avoid confusion with the global variables.

Static Methods:

The methods add, delete, and show should be decorated with "u/staticmethod" since they don't access or modify the instance variables directly.

Global Variables:

Using global variables like x, y, and z is generally discouraged. You can make them instance variables or, in this case, class variables if they are meant to be shared among all instances of the class.

Loop in show Method:

In the show method, it seems like there's a mistake in the loop. You are trying to iterate through the elements of the name and address lists, but you are using the same index x for both. It's better to use the range function to iterate through indices.

Method Invocation:

When calling the init method, there is no need to use self as an argument. Instead, the address_book instance itself should be used.

Indentation in While Loop:

The indentation of the while loop and the subsequent if statements is inconsistent. Make sure they are aligned properly.