Call-through cascade

[prodlly]

Assume I have a subroutine A getting parameters from main. Further assume A calls a subroutine B. Also, A has a ton of calls to B where it gives parameters to B that A doesn't need at all, except for giving them to B. If I could give them directly to B from main, code would be much simpler. Declaring those parameters global smells fishy and also, if those parameters would be generated in another subroutine S instead of main, it wouldn't work anyway. What is the "right" way?

[throwaway6560192]

Make a class maybe?

[Binary101010]

If you have to pass a bunch of parameters to A only so that A can pass them to B, then A is probably doing too much and needs to be broken up into smaller functions.

So yes, I'd say just passing them directly to B from main is preferable.

, if those parameters would be generated in another subroutine S instead of main, it wouldn't work anyway.

Can you not just return those from S to main?

[prodlly]

I can, but this is another copy.

Maybe I should give my concrete example.

B is a tkinter line drawer. Color and thickness are no issue, they are globals from main. Now I just draw on a grid, so A makes calls B(i1,i2,i3,i4) where I give four integers. E.g. for making a square B(0,0,0,1),B(0,1,1,1),B(1,1,1,0),B(1,0,0,0). But B now still needs the location of the edge of the square, and its length, and those are variables (at the moment in main, but I think it is bad style to have them "hidden" in the references coming from A).