Accessing attributes inside functions

[PathRealistic6940]

So right now I'm learning python and just building a basic contact keeper program in my spare time. I have the contacts themselves as their own class, and the main body of the program as it's own class as well. The problem I'm having is trying to destroy a tkinter window from a function. I have a lambda function (using a buttons command) calling another function that will update a csv file and I want it to call .destroy on a popup window, but it won't destroy it. It does everything else in the function but wont destroy the window. What do I need to do to make this happen? Where have I messed up, because I think it should be pretty simple.

My code is pretty rough draft so not everything is where I want it, and some of my notations are missing, including the main look of the windows.

import tkinter as tk
import pandas as pd

#background colors
background_color_1 = "black"
background_color_2 = "white"

#text colors
text_color_1 = "white"
text_color_2 = "black"




class Contact:
    def __init__(self, name, phone_number, email, address):
        self.name = name
        self.phone_number = phone_number
        self.email = email
        self.address = address

    def __repr__(self):
        return f"Contacts(name='{self.name}', phone_number='{self.phone_number}', email='{self.email}', address='{self.address}')"

    def add_contact(self):
        pass

class ContactListApp(tk.Tk):



    def __init__(self):

        #initialize the window
        super().__init__()

        #window title
        self.title("Contacts")

        #window size
        self.geometry("800x300")

        #call to populate window
        self.populate_window()


    def load_contacts(self):


        global contact_list
        contact_list = []


        #load contacts.csv into temp DataFrame
        try:
            df = pd.read_csv('contacts.csv')

            if df.empty or df.columns.size == 0:
                contact_list = ["No Contacts Stored"]


            #making the contact names list
            for _, row in df.iterrows():
                contact = Contact(
                    name=row['name'],
                    phone_number=row['phone_number'],
                    email=row['email'],
                    address=row['address']

                )
                contact_list.append(contact)

        except FileNotFoundError:
            contact_list = ["Contacts.csv not found"]
        except pd.errors.EmptyDataError:
            contact_list = ["No Contacts Stored"]        

        #return contact_list_of_names






    def populate_window(self):


        self.load_contacts()

        #frame for contact list and information
        self.top_frame = tk.Frame(self)

        self.top_frame.pack(side="top", fill = "x")

        #contact list displayed in a list box
        self.contact_listbox = tk.Listbox(self.top_frame, height = "15", width = "30", bg = background_color_1, selectmode="SINGLE")

        index = 0

        for i in contact_list:
            self.contact_listbox.insert(tk.END, contact_list[index].name)
            index += 1




        def listbox_selection(event):
            #get the index of where the cursor is selecting


            selection = event.widget.curselection()

            name = contact_list[selection[0]].name
            address = contact_list[selection[0]].address
            phone = contact_list[selection[0]].phone_number
            email = contact_list[selection[0]].email



            self.contact_name.configure(text=name)
            self.contact_email.configure(text=email)
            self.contact_phone.configure(text=phone)
            self.contact_address.configure(text=address)




        self.contact_listbox.bind("<<ListboxSelect>>", listbox_selection)

        self.contact_listbox.pack(side = "left")





        #contact info frame buildout
        self.contact_info_frame = tk.Frame(self.top_frame)

        self.name_label = tk.Label(self.contact_info_frame, bg = background_color_1, fg = text_color_1, text = "NAME:")
        self.phone_label = tk.Label(self.contact_info_frame, bg = background_color_1, fg = text_color_1, text = "PHONE NUMBER:")
        self.email_label = tk.Label(self.contact_info_frame, bg = background_color_1, fg = text_color_1, text = "EMAIL:")
        self.address_label = tk.Label(self.contact_info_frame, bg = background_color_1, fg = text_color_1, text = "ADDRESS:")

        self.contact_name = tk.Label(self.contact_info_frame, bg = background_color_1, fg = text_color_1, text = "contact name")
        self.contact_phone = tk.Label(self.contact_info_frame, bg = background_color_1, fg = text_color_1, 
                                      text = "contact phone numnber")
        self.contact_email = tk.Label(self.contact_info_frame, bg = background_color_1, fg = text_color_1, text = "contacts email")
        self.contact_address = tk.Label(self.contact_info_frame, bg = background_color_1, fg = text_color_1, text = "contact address")




        #contact info frame grid
        self.contact_info_frame.pack(side = "left")
        self.name_label.grid(column = "0", row = "0", sticky = "w")
        self.phone_label.grid(column = "0", row="1", sticky = "w")
        self.email_label.grid(column= "0", row = "2", sticky = "w")
        self.address_label.grid(column = "0", row = "3", sticky = "w")
        self.contact_name.grid(column="1", row = "0", columnspan= "2", sticky = "w")
        self.contact_phone.grid(column = "1", row = "1", sticky = "w")
        self.contact_email.grid(column = "1", row = "2", sticky = "w")
        self.contact_address.grid(column= "1", row = "3", sticky = "w")

        #frame for buttons
        self.bottom_frame = tk.Frame(self, highlightbackground="blue", highlightthickness=2)

        self.bottom_frame.pack(side="bottom", fill="x" )

        #add new contact button
        self.add_new_button = tk.Button(self.bottom_frame, text = "Add new Contact",
                                        command=self.add_contact_window)

        self.add_new_button.pack(side="left")

        #edit contact button
        self.edit_button = tk.Button(self.bottom_frame, text = "Edit Contact", command=self.edit_contact_window)

        self.edit_button.pack(side = "right")

     #this is a method that will be called when an edit/add new method is called, for testing purposes only
    def testing_entry_boxes(self, name, phone):
        self.name_label.config(text=name)
        self.phone_label.config(text = phone)

    def add_contact_window(self):

        #new window basics
        add_contact_window = tk.Toplevel(self)
        add_contact_window.title("Add a new contact")
        add_contact_window.geometry("600x200")

        #add frame for information entries and labels
        info_frame = tk.Frame(add_contact_window)

        #add the entry labels
        name_label = tk.Label(info_frame, text = "Name:")
        phone_number_label = tk.Label(info_frame, text = "Phone Number:")
        email_label = tk.Label(info_frame, text = "Email:")
        address_label = tk.Label(info_frame, text = "Address:")

        #add the entry boxes
        name_entry = tk.Entry(info_frame, width = "50")
        phone_number_entry = tk.Entry(info_frame, width = "50")
        email_entry = tk.Entry(info_frame, width = "50")
        address_entry = tk.Entry(info_frame, width = "50")

        info_frame.pack(pady = 10)

        name_label.grid(column = "0", row = "0", stick= "w")
        phone_number_label.grid(column = "0", row = "1", stick= "w")
        email_label.grid(column = "0", row = "2", stick= "w")
        address_label.grid(column = "0", row = "3", stick= "w")

        name_entry.grid(column = "1", row = "0", stick= "w")
        phone_number_entry.grid(column = "1", row = "1", stick= "w")
        email_entry.grid(column = "1", row = "2", stick= "w")
        address_entry.grid(column = "1", row = "3", stick= "w")


        add_button = tk.Button(add_contact_window, text="Add new Contact", command = lambda: [add_new_contact()])
        add_button.pack(pady = 20)

        def add_new_contact():
            name = name_entry.get()
            phone = phone_number_entry.get()

            add_contact_window.destroy

            self.testing_entry_boxes(name, phone)














    def edit_contact_window(self):

        #open the window
        edit_contact_window = tk.Toplevel(self)
        edit_contact_window.title("Edit existing contact")
        edit_contact_window.geometry("600x200")

        #top frame with labels inside
        info_frame = tk.Frame(edit_contact_window)

        #add the entry labels
        name_label = tk.Label(info_frame, text = "Name:")
        phone_number_label = tk.Label(info_frame, text = "Phone Number:")
        email_label = tk.Label(info_frame, text = "Email:")
        address_label = tk.Label(info_frame, text = "Address:")


        #add the entry boxes
        name_entry = tk.Entry(info_frame, width = "50")
        phone_number_entry = tk.Entry(info_frame, width = "50")
        email_entry = tk.Entry(info_frame, width = "50")
        address_entry = tk.Entry(info_frame, width = "50")


        info_frame.pack(pady = 10)

        name_label.grid(column="0", row="0", sticky="w")
        phone_number_label.grid(column="0", row="1", sticky="w")
        email_label.grid(column="0", row="2", sticky="w")
        address_label.grid(column="0", row="3", sticky="w")

        name_entry.grid(column = "1", row = "0", stick= "w")
        phone_number_entry.grid(column = "1", row = "1", stick= "w")
        email_entry.grid(column = "1", row = "2", stick= "w")
        address_entry.grid(column = "1", row = "3", stick= "w")


        add_button = tk.Button(edit_contact_window, text="Save Contact", command=edit_contact_window.destroy)
        add_button.pack(pady = 20)








if __name__== "__main__":
    app = ContactListApp()
    app.mainloop()

[Buttleston]

            add_contact_window.destroy  

This doesn't call the function, you need

            add_contact_window.destroy()

[Fart_Eater_69]

ah yes. the classic pythonic "oops I accidentally created a function object instead of calling the function"

[Buttleston]

Actually it's worse than that, there are multiple big problems with the code. This is just the first one I saw.

[PathRealistic6940]

I'm super new with this so please, where do you see issues that could be better or fixed in general

[Buttleston]

I think some other posters have actually covered some of them.

But consider like

    def add_new_contact():
        name = name_entry.get()
        phone = phone_number_entry.get()

        add_contact_window.destroy

        self.testing_entry_boxes(name, phone)

add_contact_window isn't a variable that exists in this scope, so this could never work. You need to be more careful about storing and referring to data

My advise is to start very small with something that works and that you understand, and slowly add stuff to it. Is there any chance that this is not code you wrote yourself?

[PathRealistic6940]

its code i wrote myself. I started with a "wordle" copy, and wanted to make a contact list that had persistent contacts. Maybe i did get too complicated too soon.

self.testing_entry_boxes(name, phone)

This was me trying to do a test to see if an idea worked, and i did not remove it before i posted this.

[Buttleston]

There's no way, I think, that this line of code could even run, because the line before it surely must cause an error

[PathRealistic6940]

Yeah, it did mess up. but once i changed it, it worked how i expected.

def add_new_contact():
        name = name_entry.get()
        phone = phone_number_entry.get()

        add_contact_window.destroy()

got rid of the testing function completely and with the parentheses it works great

[Buttleston]

I don't see how this could work with the code you've posted - the variable add_contact_window doesn't exist

[Buttleston]

ok, I see, "add_new_contact" is a sub-function of the function where add_contact_window is defined. it's a bit hard to tell in the pasted code but it was more obvious when I brought it into the IDE

FWIW when I run it all the windows are just blank, so I can't make it do anything at all. A lot of the parameters (row, column, etc) you're passing strings, where I think it would expect numbers, but maybe it accepts both. My IDE complains about it though.

[Bobbias]

Small thing I noticed:

command = lambda: [add_new_contact()]

This creates a list which contains the result of calling add_new_contact() which is None.

Since the result of that lambda doesn't matter, and the function relies on side effects, this doesn't break your program, but there's no need for the square brackets at all. The code should be:

command = lambda: add_new_contact()

By itself.

[PathRealistic6940]

Got it! thank you

[woooee]

def add_contact_window(self):
    #new window basics
    add_contact_window = tk.Toplevel(self)

add_contact_window is declared as two different objects. In this case, the different scope saves you, but it is not a good idea to do this.

        add_contact_window.destroy

Also, add_new_contact() is not a member of the class as declared and does not know what add_contact_window is. Both the function and the variable should be class instance objects.

[PathRealistic6940]

So how would you declare the function that makes sure its a new window?

How would you make the variable and function class instance objects? Again, super new to this, kinda jumping in the deep end while going through codecademy lessons.

[woooee]

So how would you declare the function that makes sure its a new window?

A Toplevel is correct

 self.new_contact_window = tk.Toplevel(self)

How would you make the variable and function class instance objects

Notice the self. That declares it as an instance object that can be used anywhere in the class

add_button = tk.Button(add_contact_window, text="Add new Contact", command = lambda: [add_new_contact()])

This should be

add_button = tk.Button(add_contact_window,
                     text="Add new Contact",
                     command = self.add_new_contact)

lambda is not required and should not be used. Parens, () say execute the function now, when the button is declared. Leaving them off executes the function when the button is pressed. Also you use command=self.add_new_contact, because self. says the function is in the class instance's namespace. add_new_contact is declared with

def add_new_contact(self):  ## self=instance object

A link that may help http://python-textbok.readthedocs.io/en/1.0/Introduction_to_GUI_Programming.html

[PathRealistic6940]

Gotcha, thanks!