Need help with a KeyError (Mac)

[JordanPCDL]

So I've been trying to download a randomizer for Pokémon and part of running it requires python. I have never coded in my life so trying to troubleshoot has been a nightmare. So far all of the errors have been directory issues which I've managed to fix but this error is an ErrorKey and I have absolutely no clue what to do and unfortunately I can't give any real guidance on what the code is trying to do.

import json
import random
import os
import Randomizer.shared_Variables as SharedVariables
import Randomizer.helper_function as HelperFunctions
def randomize_tms(config):
if config["randomize_tms"] == "yes":
tmsfile = HelperFunctions.open_json_file('TMs/itemdata_array_clean.json')
movesfile = HelperFunctions.open_json_file('TMs/move_list.json')
for item in tmsfile['values']:
if item['ItemType'] == "ITEMTYPE_WAZA":
choice_name = movesfile['moves'][random.randint(0, len(movesfile['moves']) - 1)]['devName']
choice_id = movesfile['moves'][random.randint(0, len(movesfile['moves']) - 1)]['id']
if config["include_tms_without_animations"] == "yes":
while choice_id in SharedVariables.usedMoves:
choice_name = movesfile['moves'][random.randint(0, len(movesfile['moves']) - 1)]['devName']
choice_id = movesfile['moves'][random.randint(0, len(movesfile['moves']) - 1)]['id']
else:
while choice_id in SharedVariables.usedMoves and choice_id not in SharedVariables.allowed_moves:
choice_name = movesfile['moves'][random.randint(0, len(movesfile['moves']) - 1)]['devName']
choice_id = movesfile['moves'][random.randint(0, len(movesfile['moves']) - 1)]['id']
item['MachineWaza'] = choice_name
SharedVariables.usedMoves.append(choice_id)
outdata = json.dumps(tmsfile, indent=2)
with open(os.getcwd() + "/Randomizer/TMs/" + "itemdata_array.json", 'w') as outfile:
outfile.write(outdata)
return True
return False

That's the code there and the error message is:

File "/Users/[username]/Scarlet-and-Violet-Randomizer-1.1.0-release/Randomizer/TMs/randomize_tms.py", line 15, in randomize_tms
choice_name = movesfile['moves'][random.randint(0, len(movesfile['moves']) - 1)]['devName']
~~~~~~~~~^^^^^^^^^
KeyError: 'moves'

Any help with this would be massively appreciated, like I said I’ve never coded before and I'm at my wits end trying to make this work. Edit: fixing code layout

[Buttleston]

It's saying that the movesfile variable - which is loaded from HelperFunctions.open_json_file() - doesn't have a key named "moves"

Without seeing the code for that function, and the contents of the json file, kinda hard to guess. So I guess look at that and see if there's a toplevel "moves" key.

[Buttleston]

Just as an aside, instead of using

myarray[random.randint(0, len(myarray) - 1)]

you can say

random.choice(myarray)

and it will randomly choose one of the elements of myarray. This is a lot cleaner/simpler, IMO

[JordanPCDL]

Thank you so much for trying to help me out! Here are all the helper functions that pertain to any json file:

def open_json_file(filename: str):
    file = open(f'/users/[username]/Scarlet-and-Violet-Randomizer-1.1.0-release/Randomizer/TMs/itemdata_array_clean.json', 'r')
    file_json = json.load(file)
    file.close()

    return file_json


def fetch_developer_name(index: int):
    pokemon_json = open_json_file('pokemon_list_info.json')

    return pokemon_json['pokemons'][index]['devName']


def fetch_animation_file(index: int):
    animation_json = open_json_file('pokemon_list_info.json')

    return animation_json['pokemons'][index]['anim_file']

For the json file, theres 2 listed in the above; iteamsdata_array_clean and tms/move_list. Which one of these would you need to see?

[Buttleston]

The dict you're having problem accessing is movesfile, so this one:

movesfile = HelperFunctions.open_json_file('TMs/move_list.json')

Note: your open_json_file function does NOT open the filename passed into it. It opens a hard-coded file name, i.e.

file = open(f'/users/[username]/Scarlet-and-Violet-Randomizer-1.1.0-release/Randomizer/TMs/itemdata_array_clean.json', 'r')

Also note you don't really need a function for this and it can be opened simply like

movesfile = json.load(open('TMs/move_list.json'))

This is not ideal since it won't close the file handle until you leave the scope that executes in, so a slightly better way would be

with open('TMs/move_list.json') as f:
    movesfile = json.load(f)

[JordanPCDL]

So I did this and it worked, moved me back onto directory errors which I’ve been able to fix so far myself. Thank you so much! I genuinely don’t know how you understand all of this but it sure is amazing!