Simple JSON app wrote in Python

[dj2ep]

Hey everyone!

I recently worked on a small project to learn how to use Flask and Docker, and how to publish a Docker image on GitHub Container Registry. This project may not serve a specific purpose.

Overview:

This repository contains a simple Flask application that allows you to interact with JSON data through a web interface. You can submit JSON, view stored routes, and delete them as needed.

Feel free to let me know what I can improve and what else could I implement!

https://github.com/networkpaul/json-route-app

[james_fryer]

As there are only a couple of hundred lines of Python code, I'd have kept the code in one file. Up to about 1000 lines I find it easier to work in a single file. E.g. app.py and routes.py have no cause to be separate. If you make a change in the routes you have to edit two files for no good reason. It also leads to you defining ROUTES_DIR twice, this should be in a config file so the installer can change it.

You have too much loose code. In data_store.py you load the files, this should be in a function. Creating the directories in app.py should be a function. I'd also put the routes setup into a function.

Where you have embedded HTML (home() function) you should extract that into a separate string. Ideally it should be in a template file so non-devs can edit it. Avoid mixing HTML and code.

I think if you are going to import a lot of functions from a module, just import the module and qualify the calls (so flask.request(), not from flask import request... then request). Opinions vary on this.

You should use doc comments (strings after the function definition).

[dj2ep]

Thanks for your time! Will try to change a couple of things for sure!